Skip to content

Commit

Permalink
(imp) puppeteer 23.10.0 .. 23.11.0
Browse files Browse the repository at this point in the history
  • Loading branch information
alexey-pelykh committed Dec 19, 2024
1 parent a93d7ac commit 97e8ee3
Show file tree
Hide file tree
Showing 10 changed files with 107 additions and 92 deletions.
14 changes: 3 additions & 11 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- lts/jod

env:
PUPPETEER_VERSION: 23.9.0
PUPPETEER_VERSION: 23.11.0

steps:

Expand Down Expand Up @@ -82,16 +82,8 @@ jobs:
- ubuntu-latest
- windows-latest
puppeteer-version:
- '23.0.2'
- '23.1.1'
- '23.2.2'
- '23.3.1'
- '23.4.1'
- '23.5.3'
- '23.6.1'
- '23.7.1'
- '23.8.0'
- '23.9.0'
- '23.10.4'
- '23.11.0'

steps:

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
package:
runs-on: ubuntu-latest
env:
PUPPETEER_VERSION: 23.9.0
PUPPETEER_VERSION: 23.11.0
steps:

- name: Checkout
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ await recorder.waitForTimeout(1000)

### `--headless=new` is not supported

Sadly, [it is so](https://issues.chromium.org/issues/361863270#comment2). Starting with Puppeteer v22, `--headless=new`
is used by default so the plugin overrides with `--headless=old`.
Sadly, [it is so](https://issues.chromium.org/issues/361863270#comment2). For Puppeteer v23+, the plugin enforces use
of the `chrome-headless-shell` binary.

### Bad Chrome versions

Expand Down
99 changes: 46 additions & 53 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"@ffmpeg-installer/ffmpeg": "^1.1.0"
},
"peerDependencies": {
"puppeteer-core": "^23.0.0 <23.10.0"
"puppeteer-core": "^23.10.0"
},
"devDependencies": {
"@types/fluent-ffmpeg": "^2.1.27",
Expand All @@ -56,8 +56,8 @@
"@types/which": "^3.0.4",
"@types/ws": "^8.5.13",
"jest": "^29.7.0",
"puppeteer": "23.9.0",
"puppeteer-core": "23.9.0",
"puppeteer": "23.11.0",
"puppeteer-core": "23.11.0",
"rimraf": "^6.0.1",
"ts-jest": "^29.2.5",
"ts-standard": "^12.0.2",
Expand Down
7 changes: 7 additions & 0 deletions src/NotChromeHeadlessShell.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export class NotChromeHeadlessShell extends Error {
constructor (executablePath: string) {
super('Not chrome-headless-shell: ' + executablePath)
this.name = this.constructor.name
Error.captureStackTrace(this, this.constructor)
}
}
Loading

0 comments on commit 97e8ee3

Please sign in to comment.