-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for #34 #35
Conversation
Related: status-im/nim-stew#174 |
How well does this work when passing |
Also, how big is the desire to have any workaround within the status repos, if we rename the injected name to |
works fine - this is actually where the problem manifests in our code: an |
This PR adds a workaround for the case where a global symbol is matched instead of the local
error
/value
template invalueOr
and friends, whenvalueOr
is being used in a generic context.Two options are added:
genericsOpenSym
feature, we use itBoth solutions can be disabled via compile-time options to retain the old behavior of matching the global symbol.
See also nim-lang/Nim#22605
thanks to @Araq for the macro hack and @metagn for the language fix!