-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(image_projection_based_fusion): remove downloading logic from Cmake #4904
build(image_projection_based_fusion): remove downloading logic from Cmake #4904
Conversation
@lexavtanke LGTM. Same feedback as #4905 about the commit message. Once this PR is ready for review, you can add the label |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4904 +/- ##
==========================================
- Coverage 15.75% 15.17% -0.58%
==========================================
Files 1581 1584 +3
Lines 109651 108376 -1275
Branches 34291 33038 -1253
==========================================
- Hits 17273 16445 -828
- Misses 73344 74085 +741
+ Partials 19034 17846 -1188
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alexey Panferov <[email protected]>
de0f56e
to
4cbee5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
See #3137
According to discussion above remove downloading logic from building stage. For now it will be possible to download model files either by ansible or manually as explained in this PR
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.