Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(image_projection_based_fusion): remove downloading logic from Cmake #4904

Conversation

lexavtanke
Copy link
Contributor

Description

See #3137

According to discussion above remove downloading logic from building stage. For now it will be possible to download model files either by ansible or manually as explained in this PR

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Sep 6, 2023
@esteve
Copy link
Contributor

esteve commented Sep 7, 2023

@lexavtanke LGTM. Same feedback as #4905 about the commit message. Once this PR is ready for review, you can add the label run-build-and-test-differential so that the CI triggers the build checks.

@lexavtanke lexavtanke added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.58% ⚠️

Comparison is base (0f441c1) 15.75% compared to head (de0f56e) 15.17%.
Report is 5 commits behind head on main.

❗ Current head de0f56e differs from pull request most recent head 4cbee5f. Consider uploading reports for the commit 4cbee5f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4904      +/-   ##
==========================================
- Coverage   15.75%   15.17%   -0.58%     
==========================================
  Files        1581     1584       +3     
  Lines      109651   108376    -1275     
  Branches    34291    33038    -1253     
==========================================
- Hits        17273    16445     -828     
- Misses      73344    74085     +741     
+ Partials    19034    17846    -1188     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.23% <ø> (-0.53%) ⬇️ Carriedforward from 4070355

*This pull request uses carry forward flags. Click here to find out more.

see 200 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve marked this pull request as ready for review September 20, 2023 10:08
@esteve esteve force-pushed the remove_download_image_projection_based_fusion branch from de0f56e to 4cbee5f Compare September 20, 2023 10:08
@esteve esteve enabled auto-merge (squash) September 20, 2023 10:08
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esteve esteve merged commit bbb5271 into autowarefoundation:main Sep 20, 2023
@lexavtanke lexavtanke deleted the remove_download_image_projection_based_fusion branch September 26, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants