Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12571][PM-13807] Add/Edit Folder Dialog #12487

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
+86 −56

Merge branch 'main' into vault/pm-12571/folder-dialog

7da6bf9
Select commit
Loading
Failed to load commit list.
Open

[PM-12571][PM-13807] Add/Edit Folder Dialog #12487

Merge branch 'main' into vault/pm-12571/folder-dialog
7da6bf9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 10, 2025 in 1s

34.13% (+0.00%) compared to b8f57f3

View this Pull Request on Codecov

34.13% (+0.00%) compared to b8f57f3

Details

Codecov Report

Attention: Patch coverage is 60.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 34.13%. Comparing base (b8f57f3) to head (7da6bf9).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../src/app/vault/individual-vault/vault.component.ts 0.00% 7 Missing ⚠️
...-folder-dialog/add-edit-folder-dialog.component.ts 76.47% 1 Missing and 3 partials ⚠️
...ew-item-dropdown/new-item-dropdown-v2.component.ts 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #12487   +/-   ##
=======================================
  Coverage   34.13%   34.13%           
=======================================
  Files        2936     2936           
  Lines       90433    90441    +8     
  Branches    16989    16990    +1     
=======================================
+ Hits        30869    30873    +4     
- Misses      57107    57109    +2     
- Partials     2457     2459    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov