[PM-16804] Add supporting Vault component presentational updates for blocked domains #12720
+191
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12720 +/- ##
==========================================
- Coverage 34.14% 34.12% -0.02%
==========================================
Files 2937 2937
Lines 90337 90483 +146
Branches 16961 17000 +39
==========================================
+ Hits 30846 30879 +33
- Misses 57036 57146 +110
- Partials 2455 2458 +3 ☔ View full report in Codecov by Sentry. |
|
Fixed Issues
|
jprusik
force-pushed
the
pm-16804
branch
5 times, most recently
from
8356aae to
580bf9f
Compare
jprusik
force-pushed
the
pm-16804
branch
3 times, most recently
from
66dba77 to
b7e5851
Compare
shane-melton
requested changes
Jan 8, 2025
...popup/components/vault-v2/autofill-vault-list-items/autofill-vault-list-items.component.html
Show resolved
Hide resolved
| * Flag indicating that the current tab location is blocked | ||
| */ | ||
| @Input({ transform: booleanAttribute }) | ||
| currentURIIsBlocked: boolean; |
There was a problem hiding this comment.
🎨 Instead of an input property, we can use the already injected VaultPopupAutofillService and reference the currentTabIsOnBlocklist$ observable.
We should also make use of the observable and an async pipe in the template as the current tab could change while the extension is open. (e.g. the Firefox sidebar has a "refresh current tab" button that will cause currentAutofillTab$ to re-emit)
| @@ -22,6 +22,11 @@ | |||
| </bit-no-items> | |||
| </div> | |||
|
|
|||
| <blocked-injection-banner | |||
| /** | ||
| * Flag indicating that the banner should be shown | ||
| */ | ||
| protected showScriptInjectionIsBlockedBanner = false; |
There was a problem hiding this comment.
currentAutofillTab$ observable these all depend on internally could re-emit within the lifetime of Vault page / this banner component.
The Firefox sidebar has a "refresh current tab" button that will force currentAutofillTab$ to re-emit and if we're now on a blocked tab (or vice versa) we'd want to have the UI be reactive.
Suggested change
| protected showScriptInjectionIsBlockedBanner = false; | |
| protected showScriptInjectionIsBlockedBanner$ = this.vaultPopupAutofillService.currentTabBlockedBannerIsDismissed$; |
| @@ -74,6 +72,10 @@ export class AutofillVaultListItemsComponent implements OnInit { | |||
| } | |||
|
|
|||
| async ngOnInit() { | |||
| this.currentURIIsBlocked = await firstValueFrom( | |||
There was a problem hiding this comment.
shane-melton
requested changes
Jan 9, 2025
| /** | ||
| * Flag indicating that the current tab location is blocked | ||
| */ | ||
| currentURIIsBlocked: boolean = false; |
There was a problem hiding this comment.
There was a problem hiding this comment.
ah yeah, good call; sorted in fc3823f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-16804
📔 Objective
Split from #11826 - see details in original PR
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes