Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-16804] Add supporting Vault component presentational updates for blocked domains #12720
base: main
Are you sure you want to change the base?
[PM-16804] Add supporting Vault component presentational updates for blocked domains #12720
Changes from 15 commits
285b787
7071cde
f6ff495
8d10676
f1d663c
1921e43
9dd15be
a43e72f
acab95d
cd702bf
66ad222
4fad817
4915f88
6302ad7
d79279e
fc3823f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 3 in apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts#L1-L3
Check warning on line 7 in apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts#L6-L7
Check warning on line 14 in apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts#L14
Check warning on line 16 in apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts#L16
Check warning on line 32 in apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts#L32
Check warning on line 36 in apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts#L36
Check warning on line 44 in apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts#L44
Check warning on line 48 in apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts#L48
Check warning on line 51 in apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/components/vault-v2/blocked-injection-banner/blocked-injection-banner.component.ts#L51
Check warning on line 16 in apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.ts#L15-L16
Check warning on line 130 in apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.ts#L130
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah, good call; sorted in fc3823f
Check warning on line 186 in apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.ts#L186
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐ Perfect!
Check warning on line 24 in apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/components/vault-v2/vault-v2.component.ts#L24
Check warning on line 75 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L75
Check warning on line 77 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L77
Check warning on line 79 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L79
Check warning on line 81 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L81
Check warning on line 83 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L83
Check warning on line 85 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L85
Check warning on line 94 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L94
Check warning on line 97 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L96-L97
Check warning on line 103 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L102-L103
Check warning on line 105 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L105
Check warning on line 110 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L109-L110
Check warning on line 112 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L112
Check warning on line 116 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L116
Check warning on line 121 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L118-L121
Check warning on line 123 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L123
Check warning on line 125 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L125
Check warning on line 129 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L129
Check warning on line 131 in apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts
Codecov / codecov/patch
apps/browser/src/vault/popup/services/vault-popup-autofill.service.ts#L131