Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16804] Add supporting Vault component presentational updates for blocked domains #12720

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
+191 −16

use observables in the vault-list-items-container template

fc3823f
Select commit
Loading
Failed to load commit list.
Open

[PM-16804] Add supporting Vault component presentational updates for blocked domains #12720

use observables in the vault-list-items-container template
fc3823f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 10, 2025 in 0s

34.12% (-0.02%) compared to 16a0176

View this Pull Request on Codecov

34.12% (-0.02%) compared to 16a0176

Details

Codecov Report

Attention: Patch coverage is 5.88235% with 48 lines in your changes missing coverage. Please review.

Project coverage is 34.12%. Comparing base (16a0176) to head (fc3823f).
Report is 40 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ult/popup/services/vault-popup-autofill.service.ts 11.53% 23 Missing ⚠️
...ction-banner/blocked-injection-banner.component.ts 0.00% 13 Missing ⚠️
...-container/vault-list-items-container.component.ts 0.00% 11 Missing ⚠️
...lt/popup/components/vault-v2/vault-v2.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12720      +/-   ##
==========================================
- Coverage   34.14%   34.12%   -0.02%     
==========================================
  Files        2937     2937              
  Lines       90337    90483     +146     
  Branches    16961    17000      +39     
==========================================
+ Hits        30846    30879      +33     
- Misses      57036    57146     +110     
- Partials     2455     2458       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov