bug: 재생화면 설명 뷰 버그 수정 & 플레이어뷰 옵저버 제거 코드 추가 #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a91949cbe2345b3bde0fdd9affec8b8b9173e9f5)
anyukyung
reviewed
Dec 7, 2023
| @@ -199,14 +199,14 @@ extension PlaybackViewController: PlaybackDisplayLogic { | |||
|
|
|||
| func seekVideo(viewModel: PlaybackModels.SeekVideo.ViewModel) { | |||
| let seekTime: CMTime = CMTime(value: CMTimeValue(viewModel.willMoveLocation), timescale: 1) | |||
| viewModel.curCell.playbackView.seekPlayer(seekTime: seekTime) | |||
| viewModel.curCell.playbackView.playPlayer() | |||
| viewModel.curCell.playbackView?.seekPlayer(seekTime: seekTime) | |||
anyukyung
reviewed
Dec 7, 2023
| super.init(frame: frame) | ||
| setUI() | ||
| addDescriptionAnimateGesture() | ||
| setSubViewsInPlayerViewConstraints() | ||
| // addDescriptionAnimateGesture() |
|
저 디스크립션뷰 자체에 opacity를 그라디언트로 조절하는 방법이 있을 것 같은데.. |
|
@anyukyung opacity를 어떤 방식(모양)으로 조절하면 좋을까요? 디자인적 조언을 구합니다. |
@chopmozzi 디자인은 그대로 가되, 그라데이션을 적용시키는 방법을 바꾸는게 어떻냐는 의미였어용! |
|
전 셀이 온전히 접히기 전에 접힌 gradientLayer가 바로 보여서 개선되었으면 좋겠습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
📌 변경 사항
PlaybackView 생성 방식이 달라졌습니다.
📸 ScreenShot
Simulator.Screen.Recording.-.iPhone.13.mini.-.2023-12-07.at.00.04.19.mp4
그라데이션 넘 안 이쁜거 같은데 어떻게 바꾸면 좋을지 추천 받습니다.
그리고 저만 그런건가 싶은데 저희 서버에서 나온 영상은 재생이 되다 안 되다 하네요 ㅜ
Linked Issue
close #189