-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: 재생화면 설명 뷰 버그 수정 & 플레이어뷰 옵저버 제거 코드 추가 #235
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -144,14 +144,14 @@ extension PlaybackViewController: PlaybackDisplayLogic { | |
func stopPrevPlayerAndPlayCurPlayer(viewModel: PlaybackModels.DisplayPlaybackVideo.ViewModel) { | ||
guard let tabBarHeight: CGFloat = self.tabBarController?.tabBar.frame.height else { return } | ||
if let prevCell = viewModel.prevCell { | ||
prevCell.playbackView.removePlayerSlider() | ||
prevCell.playbackView.stopPlayer() | ||
prevCell.playbackView.replayPlayer() | ||
prevCell.playbackView?.removePlayerSlider() | ||
prevCell.playbackView?.stopPlayer() | ||
prevCell.playbackView?.replayPlayer() | ||
} | ||
if let curCell = viewModel.curCell { | ||
curCell.addPlayerSlider(tabBarHeight: tabBarHeight) | ||
curCell.playbackView.addTargetPlayerSlider() | ||
curCell.playbackView.playPlayer() | ||
curCell.playbackView?.addTargetPlayerSlider() | ||
curCell.playbackView?.playPlayer() | ||
} | ||
} | ||
|
||
|
@@ -164,7 +164,7 @@ extension PlaybackViewController: PlaybackDisplayLogic { | |
} | ||
|
||
func showPlayerSlider(viewModel: PlaybackModels.DisplayPlaybackVideo.ViewModel) { | ||
viewModel.curCell?.playbackView.playerSlider?.isHidden = false | ||
viewModel.curCell?.playbackView?.playerSlider?.isHidden = false | ||
} | ||
|
||
func moveInitialPlaybackCell(viewModel: PlaybackModels.SetInitialPlaybackCell.ViewModel) { | ||
|
@@ -179,7 +179,7 @@ extension PlaybackViewController: PlaybackDisplayLogic { | |
} | ||
|
||
func leavePlaybackView(viewModel: PlaybackModels.DisplayPlaybackVideo.ViewModel) { | ||
viewModel.prevCell?.playbackView.stopPlayer() | ||
viewModel.prevCell?.playbackView?.stopPlayer() | ||
} | ||
|
||
func configureDataSource(viewModel: PlaybackModels.ConfigurePlaybackCell.ViewModel) { | ||
|
@@ -199,14 +199,14 @@ extension PlaybackViewController: PlaybackDisplayLogic { | |
|
||
func seekVideo(viewModel: PlaybackModels.SeekVideo.ViewModel) { | ||
let seekTime: CMTime = CMTime(value: CMTimeValue(viewModel.willMoveLocation), timescale: 1) | ||
viewModel.curCell.playbackView.seekPlayer(seekTime: seekTime) | ||
viewModel.curCell.playbackView.playPlayer() | ||
viewModel.curCell.playbackView?.seekPlayer(seekTime: seekTime) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. curCell이 현재 셀인가요? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 네 그렇습니다. |
||
viewModel.curCell.playbackView?.playPlayer() | ||
} | ||
|
||
func routeToBack(viewModel: PlaybackModels.DisplayPlaybackVideo.ViewModel) { | ||
var curCell = viewModel.curCell | ||
curCell?.resetObserver() | ||
curCell?.playbackView.resetPlayer() | ||
curCell?.playbackView?.resetPlayer() | ||
curCell = nil | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 주석은 사용하는 것인가욤
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안 사용해요 지울게요