feat: Make the DataProxyProvider work in Flagship app #2697
+46
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
requested review from
JF-Cozy,
Merkur39,
zatteo and
doubleface
as code owners
Ldoppea
force-pushed
the
feat/dataproxy-flagship
branch
from
5736326 to
42705b3
Compare
2 tasks
zatteo
reviewed
Jan 14, 2025
|
|
||
| log.log('Initializing DataProxy intent in Flagship app') | ||
| const isSearchAvailable = | ||
| (await webviewIntent?.call('isAvailable', 'search')) ?? false |
There was a problem hiding this comment.
nit: webviewIntent?.call : ?. has already been checked L74
zatteo
reviewed
Jan 14, 2025
| return | ||
| } | ||
|
|
||
| if (!flag('cozy.search.enabled')) { |
There was a problem hiding this comment.
nit: Maybe the flagship flag condition could be centralized with the iframe flag condition ?
zatteo
approved these changes
Jan 14, 2025
In previous implementation we disabled the DataProxy in Flagship app because this feature was not implemented yet in that environment We are working on implementing it in the Flagship app, so we want the DataProxyProvider to be able to use the Flagship's implementation This commit implements this by checking the feature availability on the Flagship app and then by redirecting the DataProxy calls through the webviewIntent
Ldoppea
force-pushed
the
feat/dataproxy-flagship
branch
from
42705b3 to
a1afc01
Compare
paultranvan
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous implementation we disabled the DataProxy in Flagship app because this feature was not implemented yet in that environment
We are working on implementing it in the Flagship app, so we want the DataProxyProvider to be able to use the Flagship's implementation
This commit implements this by checking the feature availability on the Flagship app and then by redirecting the DataProxy calls through the webviewIntent
Related PR: cozy/cozy-flagship-app#1279