feat: Implement Search API for cozy-dataproxy-api #1279
Merged
+157
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2025
Ldoppea
force-pushed
the
feat/trigger_replication_on_appstate_and_realtime
branch
from
f3aeba5 to
f50d62d
Compare
Ldoppea
force-pushed
the
feat/trigger_replication_on_appstate_and_realtime
branch
from
f50d62d to
11582fc
Compare
Ldoppea
force-pushed
the
feat/search
branch
3 times, most recently
from
7a324ba to
1322de5
Compare
zatteo
approved these changes
Jan 16, 2025
paultranvan
approved these changes
Jan 16, 2025
package.json
Outdated
| @@ -70,6 +72,7 @@ | |||
| "cozy-realtime": "^5.6.2", | |||
| "date-fns": "2.29.3", | |||
| "events": "^3.3.0", | |||
| "flexsearch": "^0.7.43", | |||
There was a problem hiding this comment.
I don't think flexsearch and comlink are necessary here? There are both dependencies from cozy-dataproxy-lib
There was a problem hiding this comment.
Nice catch, I don't remember why I added them, fixed here
|
Love how simple this looks 😄 |
paultranvan
reviewed
Jan 16, 2025
| "cozy-client": "^52.0.0", | ||
| "cozy-clisk": "^0.38.1", | ||
| "cozy-dataproxy-lib": "^2.3.0", |
There was a problem hiding this comment.
It should be 2.4.0 I assume? To get cozy/cozy-libs#2697
There was a problem hiding this comment.
It is not needed, 2.4.0 only impacts the DataProxyProvider that is hosted in web cozy-apps.
Ldoppea
force-pushed
the
feat/trigger_replication_on_appstate_and_realtime
branch
from
11582fc to
77c1030
Compare
Base automatically changed from
feat/trigger_replication_on_appstate_and_realtime
to
feat/meta_offline
January 17, 2025 11:44
For some reasons, the ReactNative API fails to resolve `cozy-dataproxy-lib/api` path so we must use `/dist` version instead On the opposite, Jest will fail to resolve the `/dist` version so we cannot mock cozy-dataproxy-lib To fix this, we wrap the imports in a local file so we can mock this local file in Jest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cozy/cozy-libs#2697 we enabled cozy-apps to use the Flagship app as a DataProxy provider
This PR is responsible to implement DataProxy features in the Flagship app and to declare that it those features are available