Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): return usedPreAggregations even in prod #9055

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

flochaz
Copy link

@flochaz flochaz commented Dec 17, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#9078

Description of Changes Made (if issue reference is not provided)

We are heavily relying on pre-aggregation and relying on job API to force rebuilt of pre aggregation.
The API support cubes or preAggregation parameter but there is no way to know what cube or preAggregation is used by a given query

@flochaz flochaz requested a review from a team as a code owner December 17, 2024 05:57
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Dec 17, 2024
@igorlukanin
Copy link
Member

Hi @flochaz 👋

Thanks for the contribution. Could you please explain what are you trying to achieve with this change? What is your use case?

ARG DEV_BUILD_IMAGE=cubejs/cube:build
ARG DEV_BUILD_IMAGE=cubejs/cube:dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why is this change needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After quick search — it seems that we do not produce cubejs/cube:build tags anymore, so I think that one was just missed. So it is ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants