Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): return usedPreAggregations even in prod #9055

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+29,729 −3
Open

feat(gateway): return usedPreAggregations even in prod #9055

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d89ccd
feat(gateway): return usedPreAggregations even in prod
Dec 17, 2024
7bb9400
Merge branch 'master' into returnUsedPreAggregation
flochaz Jan 8, 2025
09316cf
Merge branch 'master' into returnUsedPreAggregation
KSDaemon Jan 8, 2025
4ebd0e6
Merge branch 'master' into returnUsedPreAggregation
KSDaemon Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/cubejs-api-gateway/src/gateway.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1633,13 +1633,13 @@ class ApiGateway {
context.signedWithPlaygroundAuthSecret
? {
refreshKeyValues: response.refreshKeyValues,
usedPreAggregations: response.usedPreAggregations,
transformedQuery: sqlQuery.canUseTransformedQuery,
requestId: context.requestId,
}
: null
),
annotation,
requestId: context.requestId,
usedPreAggregations: response.usedPreAggregations,
dataSource: response.dataSource,
dbType: response.dbType,
extDbType: response.extDbType,
Expand Down
2 changes: 1 addition & 1 deletion packages/cubejs-docker/local.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG DEV_BUILD_IMAGE=cubejs/cube:build
ARG DEV_BUILD_IMAGE=cubejs/cube:dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why is this change needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After quick search — it seems that we do not produce cubejs/cube:build tags anymore, so I think that one was just missed. So it is ok!


FROM $DEV_BUILD_IMAGE as build
FROM node:18.20.3-bullseye-slim
Expand Down
Loading