Lucijs/adding favicon and open graph image #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdeak4
reviewed
Nov 10, 2024
| content="Komferencija koja na jednom mjestu okuplja hrvatsku IT scenu, te pruža posjetiteljima niz predavanja, radionica i prilika za networking." | ||
| /> | ||
|
|
||
| <link id="favicon" href="/src/assets/Favicon.ico" rel='icon' /> |
There was a problem hiding this comment.
ovo maknit jer se to vec setta u App.tsx (svijetla ikonica za dark theme i tamna ikonica za light theme)
There was a problem hiding this comment.
Dizajneri zele novu ikonicu da bude za google search result
There was a problem hiding this comment.
aha onda makni od tamo i prebaci sve ovdje (samo nece se vise svg importat nego ce se linkat kao tu znaci /src/assets/...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Koristila sam ekstenziju Loaclhost Open Graph Checker koja pokaze hosted full tags, i favicon i open graph su tamo. Jedino sta san bas prominila su da san pribacila sve favicon slike u ico format