Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucijs/adding favicon and open graph image #427

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Lucijs/adding favicon and open graph image #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
deca67a
added open graph image
Nov 9, 2024
cca0829
added favicon for google search
Nov 9, 2024
920a855
added favicon on google search result
Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maknit ove i dodat u gitignore

Binary file not shown.
Binary file added apps/.DS_Store
View file
Open in desktop
Binary file not shown.
12 changes: 11 additions & 1 deletion apps/web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,19 @@
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>DUMP Days</title>
<meta property='og:image' content="/src/assets/Open graph image.jpg" />
<meta property="og:type" content="website" />
<meta property="og:title" content="DUMP Days" />
<meta
property="og:description"
content="Komferencija koja na jednom mjestu okuplja hrvatsku IT scenu, te pruža posjetiteljima niz predavanja, radionica i prilika za networking."
/>

<link id="favicon" href="/src/assets/Favicon.ico" rel='icon' />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ovo maknit jer se to vec setta u App.tsx (svijetla ikonica za dark theme i tamna ikonica za light theme)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dizajneri zele novu ikonicu da bude za google search result

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha onda makni od tamo i prebaci sve ovdje (samo nece se vise svg importat nego ce se linkat kao tu znaci /src/assets/...)


</head>
<body>
<div id="root"></div>
<script type="module" src="/src/main.tsx"></script>
</body>
</html>
</html>
6 changes: 4 additions & 2 deletions apps/web/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,16 @@ import { Helmet, HelmetProvider } from 'react-helmet-async';
import { Toaster } from 'react-hot-toast';
import { Route, Switch } from 'wouter';

import faviconBlack from './assets/favicon-black.png';
import faviconWhite from './assets/favicon-white.png';
import faviconBlack from './assets/favicon-black.ico';
import faviconWhite from './assets/favicon-white.ico';

import { Path } from './constants/paths';
import { getPageTitle } from './helpers';
import { Chatbot } from './pages/Chatbot';
import { LandingPage } from './pages/LandingPage';

export const App = () => {

return (
<HelmetProvider>
<Helmet>
Expand Down
Binary file added apps/web/src/assets/Favicon.ico
View file
Open in desktop
Binary file not shown.
Binary file added apps/web/src/assets/Open graph image.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added apps/web/src/assets/favicon-black.ico
View file
Open in desktop
Binary file not shown.
Binary file removed apps/web/src/assets/favicon-black.png
View file
Open in desktop
Binary file not shown.
Binary file added apps/web/src/assets/favicon-white.ico
View file
Open in desktop
Binary file not shown.
Binary file removed apps/web/src/assets/favicon-white.png
View file
Open in desktop
Binary file not shown.
Loading