Skip to content
This repository has been archived by the owner on Aug 24, 2023. It is now read-only.

Many improvements #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlexWayfer
Copy link

Changes are described in CHANGELOG.md.

@AlexWayfer AlexWayfer changed the title Many improvements WIP: Many improvements Apr 5, 2020
@AlexWayfer
Copy link
Author

Oh, I forgot to push TwitchOAuth2 and make improvements for outdated tokens. Wait a moment, please.

@AlexWayfer AlexWayfer force-pushed the many_improvements branch 2 times, most recently from 60dc9fc to bbe76f4 Compare April 5, 2020 13:48
@AlexWayfer
Copy link
Author

Now it uses git-version of twitch_oauth2. I'll check these gems together in real-life project and then release twitch_oauth2.

@AlexWayfer
Copy link
Author

Also I can try to replace VCR with regular RSpec allowing and expectations. I don't know why my minds were clouded by new for me technology (VCR). 😅

@AlexWayfer
Copy link
Author

No, I don't want to replace. It will looks like stubs.get('user') { [200, {}, stubbed_user] } and expect(body).to match expected_user.

So, with non-real data…

Also, Twitch documentation is incorrect. For example: https://dev.twitch.tv/docs/v5/reference/users#get-user

There is id like Integer, but in real life it's a String, and for /users/:id it's documented like a String.

So, let's move with VCR cassetes.

@AlexWayfer AlexWayfer changed the title WIP: Many improvements Many improvements Apr 25, 2020
@AlexWayfer
Copy link
Author

Done, everything looks working.

Gemfile Outdated Show resolved Hide resolved
@AlexWayfer AlexWayfer changed the title Many improvements WIP: Many improvements Apr 25, 2020
@AlexWayfer AlexWayfer force-pushed the many_improvements branch from 830b2b7 to 738ef78 Compare May 23, 2020 17:10
@AlexWayfer AlexWayfer changed the title WIP: Many improvements Many improvements May 23, 2020
@AlexWayfer
Copy link
Author

This pull request is ready.

Copy link
Owner

@dustinlakin dustinlakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AlexWayfer! Sorry I missed this for so long. Feel free to merge this, I sent out permissions for you on https://rubygems.org/gems/twitch/ to update it there as well. Let me know if you need anything else. I haven't used Ruby in years so it is much better off in your hands.

Changes are described in `CHANGELOG.md`.
@AlexWayfer
Copy link
Author

Feel free to merge this

Unfortunately, I see no such button. Here is some mistake. BTW, Twitch closed the Kraken API.

@AlexWayfer AlexWayfer mentioned this pull request Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants