Update authentication #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWayfer
force-pushed
the
update_authentication
branch
from
48e63f3 to
fec5282
Compare
mauricew
requested changes
Nov 5, 2020
AlexWayfer
force-pushed
the
update_authentication
branch
from
30bb372 to
d910ddc
Compare
* Require `client_id` and `client_secret` for Application Access Token. * Use `twitch_oauth2` gem for authentication. * Drop `with_raw` option, include it always. * Drop `webmock` development dependency, use `faraday` interface for VCR. * Use `configure_rspec_metadata!` for auto-generated cassettes names. * Split `Client`'s methods into modules.
AlexWayfer
force-pushed
the
update_authentication
branch
from
a3dbe3d to
5d5849c
Compare
Merged
This was wrong, I forgot about "WIP" and its reason, sorry. |
AlexWayfer
added a commit
to AlexWayfer/twitch_oauth2
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client_idandclient_secretfor Application Access Token.twitch_oauth2gem for authentication.with_rawoption, include it always.webmockdevelopment dependency, usefaradayinterface for VCR.configure_rspec_metadata!for auto-generated cassettes names.Client's methods into modules.