Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): updated to default filtering behavior #2345

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

saiponnada
Copy link
Contributor

Description

Fixes #2343

Context

  • Updated the combobox default filtering behaviour to always filter options. To view all options viewAllOptions flag needs to be set to false
  • Updated the tests to reflect the behavior.

@saiponnada saiponnada self-assigned this Dec 17, 2024
agliga
agliga previously approved these changes Dec 17, 2024
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm can you target master

@saiponnada saiponnada changed the base branch from 14.6.0 to master December 17, 2024 20:58
@saiponnada saiponnada dismissed agliga’s stale review December 17, 2024 20:58

The base branch was changed.

@saiponnada
Copy link
Contributor Author

Lgtm can you target master

Will this be okay with my minor changeset?

@agliga
Copy link
Contributor

agliga commented Dec 17, 2024

Lgtm can you target master

Will this be okay with my minor changeset?

Change it to patch. It is a patch fix anyways

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: f7c045c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@saiponnada saiponnada merged commit 04956d5 into master Dec 17, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ebay-combobox: Is not filtering lists anymore
2 participants