fix(combobox): updated to default filtering behavior

.changeset/rich-coins-invent.md

@@ -0,0 +1,5 @@
+---
+"@ebay/ebayui-core": patch
+---
+
+fix(combobox): updated to default filtering behavior

src/components/ebay-combobox/combobox.stories.ts

@@ -59,6 +59,11 @@ export default {
             type: "boolean",
             control: { type: "boolean" },
             description: "Filters listbox options based on user input",
+            table: {
+                defaultValue: {
+                    summary: "false",
+                },
+            },
         },
         "floating-label": {
             control: { type: "text" },

src/components/ebay-combobox/component.ts

@@ -102,7 +102,7 @@ export default class Combobox extends Marko.Component<Input, State> {
         if (this.listSelection === "automatic") {
             const selected = this._getVisibleOptions()[ev.detail.toIndex];
             // Set textbox value to selected, don't update state since it messes up active descendant
-            (this.getEl("combobox") as HTMLInputElement).value = selected.text;
+            (this.getEl("combobox") as HTMLInputElement).value = selected?.text;
         }
     }
 
@@ -350,7 +350,7 @@ export default class Combobox extends Marko.Component<Input, State> {
     _getVisibleOptions() {
         if (
             this.autocomplete === "none" ||
-            (this.input.viewAllOptions ?? true)
+            (this.input.viewAllOptions ?? false)
         ) {
             return [...(this.input.options ?? [])];
         }

src/components/ebay-combobox/test/__snapshots__/test.server.js.snap

@@ -721,24 +721,6 @@ exports[`combobox > renders with second item selected 1`] = `
       class="combobox__listbox"
       role="listbox"
     >
-      <div
-        class="combobox__option"
-        role="option"
-        tabindex="-1"
-      >
-        <span>
-          August Campaign
-        </span>
-      </div>
-      <div
-        class="combobox__option"
-        role="option"
-        tabindex="-1"
-      >
-        <span>
-          4th of July Sale (paused)
-        </span>
-      </div>
       <div
         class="combobox__option"
         role="option"

src/components/ebay-combobox/test/test.browser.js

@@ -186,10 +186,11 @@ describe("given the combobox with 3 items", () => {
     }
 });
 
-describe("given the combobox with 3 items and 2 selected", () => {
+describe("given the combobox with 3 items and 2 selected and view all options", () => {
     beforeEach(async () => {
         component = await render(Isolated, {
             value: Isolated.args.options[1].text,
+            viewAllOptions: true,
         });
     });