Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21231] Complete flow_controller_descriptor references in xml sections (backport #824) #827

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 27, 2024

Description

This PR completes the flow_controller_descriptor references in xml sections for the participant and datawriter sections.

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

This is an automatic backport of pull request #824 done by [Mergify](https://mergify.com).

@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@EduPonz EduPonz force-pushed the mergify/bp/2.14.x/pr-824 branch from fb77d4a to 2125924 Compare July 3, 2024 09:35
Mario-DL and others added 2 commits July 3, 2024 11:35
* Refs #21231: Add missing <flow_controller_descriptor_list> to domainparticipant xml

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21231: Add missing <flow_controller_name> to datawriter xml qos

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Jesus rev

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Edu suggestion

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6e7f076)
Signed-off-by: eduponz <[email protected]>
@EduPonz EduPonz force-pushed the mergify/bp/2.14.x/pr-824 branch from 2125924 to c2778fd Compare July 3, 2024 09:35
@EduPonz EduPonz self-requested a review July 3, 2024 09:35
@EduPonz EduPonz merged commit c3c595b into 2.14.x Jul 3, 2024
4 checks passed
@EduPonz EduPonz deleted the mergify/bp/2.14.x/pr-824 branch July 3, 2024 09:57
@EduPonz EduPonz modified the milestones: v2.14.3, v2.14.2 Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants