Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21231] Complete flow_controller_descriptor references in xml sections #824

Merged
merged 4 commits into from
Jun 26, 2024
Merged

[21231] Complete flow_controller_descriptor references in xml sections #824

merged 4 commits into from
Jun 26, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Jun 25, 2024 •
edited by JesusPoderoso
Loading

Description

This PR completes the flow_controller_descriptor references in xml sections for the participant and datawriter sections.

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@Mario-DL Mario-DL added this to the v3.0.0 milestone Jun 25, 2024
@Mario-DL Mario-DL requested a review from JesusPoderoso June 25, 2024 08:39
@Mario-DL
Copy link
Member Author

@richiprosima please test_3 docs

@Mario-DL
Refs #21131: Apply Jesus rev
24b290b 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL
Copy link
Member Author

@richiprosima please test_3 docs

JesusPoderoso
JesusPoderoso previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EduPonz
EduPonz suggested changes Jun 25, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a reference in the full XML example

@Mario-DL
Refs #21131: Apply Edu suggestion
ccbc726 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL
Copy link
Member Author

@richiprosima please test_3 docs

@Mario-DL Mario-DL requested a review from EduPonz June 25, 2024 10:40
@EduPonz EduPonz merged commit 6e7f076 into master Jun 26, 2024
4 checks passed
@EduPonz EduPonz deleted the docs/21231 branch June 26, 2024 08:10
@Mario-DL
Copy link
Member Author

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

@mergify Mergify
Copy link

mergify bot commented Jun 27, 2024 •
edited
Loading

backport 2.14.x 2.13.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 27, 2024
@Mario-DL @mergify
Complete flow_controller_descriptor references in xml sections (#824)
fb77d4a 
* Refs #21231: Add missing <flow_controller_descriptor_list> to domainparticipant xml

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21231: Add missing <flow_controller_name> to datawriter xml qos

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Jesus rev

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Edu suggestion

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6e7f076)
@mergify mergify bot mentioned this pull request Jun 27, 2024
Merged
8 tasks
mergify bot pushed a commit that referenced this pull request Jun 27, 2024
@Mario-DL @mergify
Complete flow_controller_descriptor references in xml sections (#824)
f3660d2 
* Refs #21231: Add missing <flow_controller_descriptor_list> to domainparticipant xml

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21231: Add missing <flow_controller_name> to datawriter xml qos

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Jesus rev

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Edu suggestion

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6e7f076)

# Conflicts:
#	docs/fastdds/xml_configuration/domainparticipant.rst
mergify bot pushed a commit that referenced this pull request Jun 27, 2024
@Mario-DL @mergify
Complete flow_controller_descriptor references in xml sections (#824)
4e77a65 
* Refs #21231: Add missing <flow_controller_descriptor_list> to domainparticipant xml

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21231: Add missing <flow_controller_name> to datawriter xml qos

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Jesus rev

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Edu suggestion

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6e7f076)

# Conflicts:
#	code/XMLTester.xml
#	code/XMLTesterExample.xml
#	docs/fastdds/dds_layer/core/policy/eprosimaExtensions.rst
#	docs/fastdds/xml_configuration/domainparticipant.rst
This was referenced Jun 27, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jun 27, 2024
@Mario-DL @mergify
Complete flow_controller_descriptor references in xml sections (#824)
1856d5f 
* Refs #21231: Add missing <flow_controller_descriptor_list> to domainparticipant xml

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21231: Add missing <flow_controller_name> to datawriter xml qos

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Jesus rev

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Edu suggestion

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6e7f076)

# Conflicts:
#	code/XMLTester.xml
#	code/XMLTesterExample.xml
#	docs/fastdds/dds_layer/core/policy/eprosimaExtensions.rst
#	docs/fastdds/xml_configuration/common.rst
#	docs/fastdds/xml_configuration/domainparticipant.rst
@mergify mergify bot mentioned this pull request Jun 27, 2024
Closed
8 tasks
EduPonz pushed a commit that referenced this pull request Jul 3, 2024
@Mario-DL @EduPonz
Complete flow_controller_descriptor references in xml sections (#824)
a312713 
* Refs #21231: Add missing <flow_controller_descriptor_list> to domainparticipant xml

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21231: Add missing <flow_controller_name> to datawriter xml qos

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Jesus rev

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Edu suggestion

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6e7f076)
EduPonz pushed a commit that referenced this pull request Jul 3, 2024
@Mario-DL @EduPonz
Complete flow_controller_descriptor references in xml sections (#824)
1094d84 
* Refs #21231: Add missing <flow_controller_descriptor_list> to domainparticipant xml

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21231: Add missing <flow_controller_name> to datawriter xml qos

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Jesus rev

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Edu suggestion

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6e7f076)
Signed-off-by: eduponz <[email protected]>
EduPonz added a commit that referenced this pull request Jul 3, 2024
@mergify @Mario-DL @EduPonz
Complete flow_controller_descriptor references in xml sections (#824) (…
c3c595b 
…#827)

* Complete flow_controller_descriptor references in xml sections (#824)

* Refs #21231: Add missing <flow_controller_descriptor_list> to domainparticipant xml

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21231: Add missing <flow_controller_name> to datawriter xml qos

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Jesus rev

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Edu suggestion

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6e7f076)
Signed-off-by: eduponz <[email protected]>

* Refs #21231: Fix XML snippet range

Signed-off-by: eduponz <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: eduponz <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
Co-authored-by: eduponz <[email protected]>
JesusPoderoso pushed a commit that referenced this pull request Jul 12, 2024
@Mario-DL @JesusPoderoso
Complete flow_controller_descriptor references in xml sections (#824)
e54feb5 
* Refs #21231: Add missing <flow_controller_descriptor_list> to domainparticipant xml

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21231: Add missing <flow_controller_name> to datawriter xml qos

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Jesus rev

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Edu suggestion

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6e7f076)

# Conflicts:
#	docs/fastdds/xml_configuration/domainparticipant.rst
EduPonz pushed a commit that referenced this pull request Jul 12, 2024
@mergify @Mario-DL @JesusPoderoso
Complete flow_controller_descriptor references in xml sections (#824) (…
f441bea 
…#828)

* Complete flow_controller_descriptor references in xml sections (#824)

* Refs #21231: Add missing <flow_controller_descriptor_list> to domainparticipant xml

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21231: Add missing <flow_controller_name> to datawriter xml qos

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Jesus rev

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Edu suggestion

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6e7f076)

# Conflicts:
#	docs/fastdds/xml_configuration/domainparticipant.rst

* Refs: 21231: Fix conflicts

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
Co-authored-by: JesusPoderoso <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Sep 12, 2024
@Mario-DL @MiguelCompany
Complete flow_controller_descriptor references in xml sections (#824)
ffb24e5 
* Refs #21231: Add missing <flow_controller_descriptor_list> to domainparticipant xml

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21231: Add missing <flow_controller_name> to datawriter xml qos

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Jesus rev

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21131: Apply Edu suggestion

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Sep 12, 2024
@mergify @Mario-DL
Complete flow_controller_descriptor references in xml sections (#824) (…
fbd01d3 
…#829)

* Refs #21231: Add missing <flow_controller_descriptor_list> to domainparticipant xml



* Refs #21231: Add missing <flow_controller_name> to datawriter xml qos



* Refs #21131: Apply Jesus rev



* Refs #21131: Apply Edu suggestion



---------

Signed-off-by: Mario Dominguez <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

@JesusPoderoso JesusPoderoso JesusPoderoso left review comments

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Mario-DL @EduPonz @JesusPoderoso