-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1295 Extend FAQ with more questions #1434
iox-#1295 Extend FAQ with more questions #1434
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1434 +/- ##
==========================================
- Coverage 78.74% 78.71% -0.04%
==========================================
Files 377 377
Lines 14505 14505
Branches 2020 2020
==========================================
- Hits 11422 11417 -5
- Misses 2441 2443 +2
- Partials 642 645 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Oh, while you are at it. Could you add a clarification that the d'tor of the data is not called to https://iceoryx.io/v2.0.2/getting-started/overview/#restrictions? |
7763a1c
to
db88121
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a bit more clarification regarding the destructor constraint
@dkroenke can you please add the issue number to your commit |
5074003
to
7c8ef4c
Compare
Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Simon Hoinkis <[email protected]>
7c8ef4c
to
cc3eda0
Compare
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
v3.0
#1295