Stop including including org.eclipse.jdt.annotation_v1 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems we don't have a full-blown PR build here. So perhaps someone may want to review? @akurtakov or @iloveeclipse ? |
|
What should we review? If that thing is not needed by JDT anymore, it is OK not to include it. |
Good question about PDE :) -- but I don't see any such dependency there either. |
akurtakov
added a commit
to akurtakov/eclipse.jdt.core
that referenced
this pull request
Oct 18, 2024
Ensure that o.e.jdt.annotations 1.x is not picked by accident when there is unversioned require (like eclipse-jdt/eclipse.jdt#118 ) as it will no longer be in the reactor.
stephan-herrmann
pushed a commit
to eclipse-jdt/eclipse.jdt.core
that referenced
this pull request
Oct 18, 2024
Ensure that o.e.jdt.annotations 1.x is not picked by accident when there is unversioned require (like eclipse-jdt/eclipse.jdt#118 ) as it will no longer be in the reactor.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This concludes the move of eclipse-jdt/eclipse.jdt.core#3029 and eclipse-jdt/eclipse.jdt.ui#1712 by which are stopping to ship two versions of org.eclipse.jdt.annotation.