Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: bind mount gomodcache to cache go dependencies #41846

Merged
merged 10 commits into from
Dec 3, 2024

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Dec 1, 2024

Proposed commit message

try to speed up ci jobs integration tests
bind host go mod cache to container /go/pkg/mod

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

try to speed up ci jobs integration tests
@kruskall kruskall requested a review from a team as a code owner December 1, 2024 17:48
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 1, 2024
Copy link
Contributor

mergify bot commented Dec 1, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kruskall? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Dec 1, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 1, 2024
@kruskall kruskall marked this pull request as draft December 1, 2024 23:43
instead of binding the volume on each dockerfile, run the container
with the proper volume arg
can't really bind using hostpath in k8s
since it's a local cluster, use kind to bind the hostpath to the node
then bind the node path to the container path
@kruskall kruskall marked this pull request as ready for review December 2, 2024 04:22
@kruskall
Copy link
Member Author

kruskall commented Dec 2, 2024

x-pack/metricbeat: Go Integration Tests (Module) went from ~24m to ~18m
metricbeat: Go Integration Tests (Module) went from ~34m to ~24m

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Dec 2, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 2, 2024
@kruskall kruskall merged commit 9045642 into elastic:main Dec 3, 2024
142 checks passed
@kruskall kruskall deleted the ci/cache-docker-compose branch December 3, 2024 19:29
mergify bot pushed a commit that referenced this pull request Dec 3, 2024
* test: bind mount gomodcache to cache go dependencies

try to speed up ci jobs integration tests

* test(metricbeat): do not make gomodcache readonly

* lint: replace ioutil usage

* test: fail on empty gomodcache

* test: rework cache bind approach

instead of binding the volume on each dockerfile, run the container
with the proper volume arg

* test: bind gomodcache in kubernetes runner

* test: sync the gomodcache with rsync and fix linter issues

can't really bind using hostpath in k8s

* test: rework bind approach with k8s runner

since it's a local cluster, use kind to bind the hostpath to the node
then bind the node path to the container path

* lint: remove unused imports

* lint: fix linter issues

(cherry picked from commit 9045642)
kruskall added a commit that referenced this pull request Dec 5, 2024
* test: bind mount gomodcache to cache go dependencies

try to speed up ci jobs integration tests

* test(metricbeat): do not make gomodcache readonly

* lint: replace ioutil usage

* test: fail on empty gomodcache

* test: rework cache bind approach

instead of binding the volume on each dockerfile, run the container
with the proper volume arg

* test: bind gomodcache in kubernetes runner

* test: sync the gomodcache with rsync and fix linter issues

can't really bind using hostpath in k8s

* test: rework bind approach with k8s runner

since it's a local cluster, use kind to bind the hostpath to the node
then bind the node path to the container path

* lint: remove unused imports

* lint: fix linter issues

(cherry picked from commit 9045642)

Co-authored-by: kruskall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants