#2294 Fix Accessibility Violations - 2

[srikant-ch5]

Ref: #2294

Fixes Notification Icon Accessibility Violation.

Fixes Properties Table Icon Accessibility Violations.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

[matthoward366]

Does carbon have this icon? We shouldn't need to include most icons as this point.

[srikant-ch5]

Does carbon have this icon? We shouldn't need to include most icons as this point.

I have updated ArrangeVertical, ArrangeHorizontal and Notification SVG's with Carbon Icons.

[matthoward366]

Can we delete the replaced icons?

[matthoward366]

@tomlyn can you review this?

[tomlyn]

Hi Srikant
While I think it's a good idea to replace the icons with those from the Carbon Icons Library this change has unfortunately removed some function.

That is, in the current code when the notification panel contains messages, the 'dot' in the notification counter icon is colored to indicate the top-most severity of the messages shown in the panel.

You can test this in the test harness by adding a message using the API right flyout. When you add a message you can set its severity ("message type") and the dot will be colored based on which is the most severe message. Like this:

Unless we get approval from Design to remove this function we probably ought to keep it working the same way.

[srikant-ch5]

Hi Srikant While I think it's a good idea to replace the icons with those from the Carbon Icons Library this change has unfortunately removed some function.

That is, in the current code when the notification panel contains messages, the 'dot' in the notification counter icon is colored to indicate the top-most severity of the messages shown in the panel.

@tomlyn I have reverted that Notification Icon change and included aria-label to fix Accessibility Violation in that SVG.

Also included aria-label for d3-svg-canvas-div keyboard-navigation to resolve below Violation.

[tomlyn]

LGTM