Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2294 Fix Accessibility Violations - 2 #2295

Merged
merged 9 commits into from
Jan 16, 2025
Merged

#2294 Fix Accessibility Violations - 2 #2295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
94da5a9
#2294 Fix Accessibility Violations - 2
srikant-ch5 Jan 9, 2025
636f9cd
Replace SVG with carbon icons
srikant-ch5 Jan 10, 2025
2be4442
Merge branch 'main' into Accessibility-Violations-Fix
srikant-ch5 Jan 13, 2025
1e8bd88
Detle Arrange Horizontal and Vertical svgs
srikant-ch5 Jan 13, 2025
cc9cb0f
Delete Notification SVG
srikant-ch5 Jan 13, 2025
a8cdcc6
Merge branch 'main' into Accessibility-Violations-Fix
srikant-ch5 Jan 15, 2025
9f07d58
Resolve Accessibility Violation for Keyboard Navigation Div by includ…
srikant-ch5 Jan 15, 2025
fab593e
Add back Notification Icon in toolbar
srikant-ch5 Jan 15, 2025
3ba9fa3
Fix build issue
srikant-ch5 Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion canvas_modules/common-canvas/assets/images/arrange_horizontally.svg
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion canvas_modules/common-canvas/assets/images/arrange_vertically.svg
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion canvas_modules/common-canvas/assets/images/notification_counter_icon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions canvas_modules/common-canvas/src/common-canvas/cc-contents.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,7 @@ class CanvasContents extends React.Component {
onMouseDown={this.onMouseDown} onMouseLeave={this.onMouseLeave}
onBlur={this.onBlur}
onKeyDown={this.onKeyDown} onKeyUp={this.onKeyUp}
role="application" aria-label="canvas-keyboard-navigation" // Resolve Accessibility Violation of role and label
/>
);
}
Expand Down
2 changes: 1 addition & 1 deletion canvas_modules/common-canvas/src/icons/icon.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export default class Icon extends React.Component {
icon = this.getCanvasIcon(this.props.type);
if (typeof icon !== "undefined") {
const className = classNames("canvas-icon", iconClassName, this.props.className);
icon = <SVG src={icon} className={className} disabled={this.props.disabled} />;
icon = <SVG src={icon} className={className} disabled={this.props.disabled} aria-label={this.props.type} />;
} else {
icon = <div />;
}
Expand Down
10 changes: 3 additions & 7 deletions canvas_modules/common-canvas/src/toolbar/toolbar-button-item.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ import React from "react";
import PropTypes from "prop-types";

import Tooltip from "../tooltip/tooltip.jsx";
import ArrangeHorizontally from "./../../assets/images/arrange_horizontally.svg";
srikant-ch5 marked this conversation as resolved.
Show resolved Hide resolved
import ArrangeVertically from "./../../assets/images/arrange_vertically.svg";
import ToggleNotificationPanel from "./../../assets/images/notification_counter_icon.svg";

import { Button } from "@carbon/react";
Expand All @@ -29,7 +27,7 @@ import { StopFilledAlt, Play, Undo, Redo, Chat, ChatOff, Result,
Cut, Copy, Paste, Edit, ColorPalette, Maximize, Minimize,
Launch, AddComment, TrashCan, ZoomIn, ZoomOut,
Checkmark, ChevronRight, ChevronDown, ChevronUp,
CenterToFit, OpenPanelFilledLeft } from "@carbon/react/icons";
CenterToFit, OpenPanelFilledLeft, ArrangeVertical, ArrangeHorizontal } from "@carbon/react/icons";
import { TOOLBAR_STOP, TOOLBAR_RUN, TOOLBAR_UNDO, TOOLBAR_REDO,
TOOLBAR_CUT, TOOLBAR_COPY, TOOLBAR_PASTE, TOOLBAR_CLIPBOARD,
TOOLBAR_CREATE_COMMENT, TOOLBAR_CREATE_AUTO_COMMENT,
Expand Down Expand Up @@ -123,12 +121,10 @@ class ToolbarButtonItem extends React.Component {
return <OpenPanelFilledLeft disabled={disabled} />;
case (TOOLBAR_TOGGLE_PALETTE):
return <OpenPanelFilledLeft disabled={disabled} />;

// Non-carbon icons
case (TOOLBAR_ARRANGE_HORIZONALLY):
return <SVG src={ArrangeHorizontally} disabled={disabled} />;
return <ArrangeHorizontal disabled={disabled} />;
case (TOOLBAR_ARRANGE_VERTICALLY):
return <SVG src={ArrangeVertically} disabled={disabled} />;
return <ArrangeVertical disabled={disabled} />;
case (TOOLBAR_TOGGLE_NOTIFICATION_PANEL):
return <SVG src={ToggleNotificationPanel} disabled={disabled} />;

Expand Down
Loading