Convert to monorepo and allow pkg to participate in monorepo package resolution #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Dec 1, 2023
| @@ -5,15 +5,13 @@ | |||
| "url": "[email protected]:embroider-build/content-tag.git" | |||
| }, | |||
| "scripts": { | |||
| "test": "mocha" | |||
| "build": "wasm-pack build --target=nodejs && rm pkg/.gitignore", | |||
There was a problem hiding this comment.
the removal of the .gitignore here is temporary, because we need the package.json for the monorepo layout reasons.
the PR on top of this one, https://github.com/embroider-build/content-tag/pull/43/files can re-ignore these files, because the wasm-pack output is in a sub-directory, which means we can keep the package.json
This was referenced Dec 1, 2023
|
These changes are not needed because we went with a non-monorepo approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top-level files remain the same.
One of the features of pnpm is that the
.directory can be its own workspace.This is extracted from #41
which was done so that the
tests/browserpackage could use vite and allow vite to correctly resolve thecontent-tagpackage which is located atpkg/(which now has its assets committed).This also enables us to commit a
index.d.tsafter generating our own package.json: https://github.com/embroider-build/content-tag/pull/41/files#diff-c174d28eed9f8ab4086afbf40d445f0e42bd47a0baf8057e6f91dc449b50b219which I can PR separately after this PR.