-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
word-count: check counting of empty words #1446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpottsoh
requested changes
Jan 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated change at end of file also need to update "version", see Travis CI output.
See https://github.com/exercism/problem-specifications#test-data-versioning |
rpottsoh
approved these changes
Jan 27, 2019
tejasbubane
added a commit
to tejasbubane/haskell
that referenced
this pull request
Mar 25, 2019
Added two tests: * Multiple whitespace - exercism/problem-specifications#1023 * Empty words - exercism/problem-specifications#1446
sshine
pushed a commit
to exercism/haskell
that referenced
this pull request
Mar 26, 2019
Added two tests: * Multiple whitespace - exercism/problem-specifications#1023 * Empty words - exercism/problem-specifications#1446
marko213
added a commit
to marko213/exercism-cpp
that referenced
this pull request
Jul 30, 2019
Adds three test cases: * substrings_from_the_beginning (exercism/problem-specifications#1557) * multiple_spaces_not_detected_as_a_word (exercism/problem-specifications#1023) * alternating_word_separators_not_detected_as_a_word (exercism/problem-specifications#1446)
arcuru
pushed a commit
to exercism/cpp
that referenced
this pull request
Aug 5, 2019
* Word-count - update tests specification to version 1.4.0 Adds three test cases: * substrings_from_the_beginning (exercism/problem-specifications#1557) * multiple_spaces_not_detected_as_a_word (exercism/problem-specifications#1023) * alternating_word_separators_not_detected_as_a_word (exercism/problem-specifications#1446) * Word-count - change test cases to be more like the specification (1.4.0) This reorders and removes some tests to match the specification in version 1.4.0 * Word-count - make empty lines uniform in test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran across the following solution on the go track that will count empty words on some inputs:
The added test catches that behaviour.