Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typeahead for hosted data cube #3824

Merged

Conversation

MauricioUyaguari
Copy link
Member

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@MauricioUyaguari MauricioUyaguari marked this pull request as ready for review January 21, 2025 21:16
Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: 4a5d905

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@finos/legend-application-data-cube Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

CLA Missing ID CLA Not Signed

@MauricioUyaguari MauricioUyaguari requested a review from a team as a code owner January 21, 2025 21:16
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 45.46%. Comparing base (3255af4) to head (4a5d905).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ta-cube/src/stores/LegendDataCubeDataCubeEngine.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3824      +/-   ##
==========================================
+ Coverage   45.44%   45.46%   +0.01%     
==========================================
  Files        2245     2245              
  Lines      390496   390501       +5     
  Branches    10759    16783    +6024     
==========================================
+ Hits       177462   177528      +66     
+ Misses     212569   211947     -622     
- Partials      465     1026     +561     
Files with missing lines Coverage Δ
...ta-cube/src/stores/LegendDataCubeDataCubeEngine.ts 0.00% <0.00%> (ø)

... and 407 files with indirect coverage changes

@MauricioUyaguari MauricioUyaguari merged commit f49e1a5 into finos:master Jan 21, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants