Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typeahead for hosted data cube #3824

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix typeahead for hosted data cube #3824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changeset/many-many-problems.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
'@finos/legend-application-data-cube': patch
---
9 changes: 7 additions & 2 deletions packages/legend-application-data-cube/src/stores/LegendDataCubeDataCubeEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
type V1_Lambda,
type V1_ValueSpecification,
type V1_EngineServerClient,
type V1_PureGraphManager,
V1_PureGraphManager,
type V1_PureModelContext,
type ExecutionResult,
type V1_ExecutionResult,
Expand All @@ -43,6 +43,7 @@ import {
V1_EngineError,
V1_PackageableType,
V1_deserializeRawValueSpecificationType,
V1_Protocol,
} from '@finos/legend-graph';
import {
_elementPtr,
Expand Down Expand Up @@ -166,7 +167,11 @@ export class LegendDataCubeDataCubeEngine extends DataCubeEngine {
source.runtime = executionContext.runtime;
source.model = V1_serializePureModelContext(
new V1_PureModelContextPointer(
undefined,
// TODO: remove as backend should handle undefined protocol input
new V1_Protocol(
V1_PureGraphManager.PURE_PROTOCOL_NAME,
PureClientVersion.VX_X_X,
),
new V1_LegendSDLC(
queryInfo.groupId,
queryInfo.artifactId,
Expand Down
Loading