New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment): use Config instead of ConfigBackoff when fetching deploy config #1239

Merged

wass3rw3rk merged 2 commits into main from fix/no-deploy-config-backoff

Jan 10, 2025

+1 −1

Merged

fix(deployment): use Config instead of ConfigBackoff when fetching deploy config #1239

Merge branch 'main' into fix/no-deploy-config-backoff

GitHub Actions / golangci failed Jan 10, 2025 in 1s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (10)

compiler/native/expand.go|396 col 33| string golang has 3 occurrences, make it a constant (goconst)
compiler/native/compile_test.go|2449 col 13| SA1019: github.String is deprecated: use Ptr instead. (staticcheck)
compiler/native/compile_test.go|2450 col 13| SA1019: github.String is deprecated: use Ptr instead. (staticcheck)
scm/github/app_permissions.go|62 col 20| SA1019: github.String is deprecated: use Ptr instead. (staticcheck)
scm/github/deployment.go|180 col 21| SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)
scm/github/repo.go|209 col 11| SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)
scm/github/repo.go|283 col 11| SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)
scm/github/github_client_test.go|76 col 9| SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)
scm/github/github_client_test.go|90 col 9| SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)
scm/github/github_client_test.go|104 col 9| SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)

Filtered Findings (0)

Annotations

Check failure on line 396 in compiler/native/expand.go

github-actions / golangci

[golangci] compiler/native/expand.go#L396

string `golang` has 3 occurrences, make it a constant (goconst)

Raw output


            compiler/native/expand.go:396:33: string `golang` has 3 occurrences, make it a constant (goconst)
	case constants.PipelineTypeGo, "golang", "":
	                               ^

Check failure on line 2449 in compiler/native/compile_test.go

github-actions / golangci

[golangci] compiler/native/compile_test.go#L2449

SA1019: github.String is deprecated: use Ptr instead. (staticcheck)

Raw output


            compiler/native/compile_test.go:2449:13: SA1019: github.String is deprecated: use Ptr instead. (staticcheck)
		Encoding: github.String(""),
		          ^

Check failure on line 2450 in compiler/native/compile_test.go

github-actions / golangci

[golangci] compiler/native/compile_test.go#L2450

SA1019: github.String is deprecated: use Ptr instead. (staticcheck)

Raw output


            compiler/native/compile_test.go:2450:13: SA1019: github.String is deprecated: use Ptr instead. (staticcheck)
		Content:  github.String(string(body)),
		          ^

Check failure on line 62 in scm/github/app_permissions.go

github-actions / golangci

[golangci] scm/github/app_permissions.go#L62

SA1019: github.String is deprecated: use Ptr instead. (staticcheck)

Raw output


            scm/github/app_permissions.go:62:20: SA1019: github.String is deprecated: use Ptr instead. (staticcheck)
		perms.Contents = github.String(perm)
		                 ^

Check failure on line 180 in scm/github/deployment.go

github-actions / golangci

[golangci] scm/github/deployment.go#L180

SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)

Raw output


            scm/github/deployment.go:180:21: SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)
		AutoMerge:        github.Bool(false),
		                  ^

Check failure on line 209 in scm/github/repo.go

github-actions / golangci

[golangci] scm/github/repo.go#L209

SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)

Raw output


            scm/github/repo.go:209:11: SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)
		Active: github.Bool(true),
		        ^

Check failure on line 283 in scm/github/repo.go

github-actions / golangci

[golangci] scm/github/repo.go#L283

SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)

Raw output


            scm/github/repo.go:283:11: SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)
		Active: github.Bool(true),
		        ^

Check failure on line 76 in scm/github/github_client_test.go

github-actions / golangci

[golangci] scm/github/github_client_test.go#L76

SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)

Raw output


            scm/github/github_client_test.go:76:9: SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)
				ID: github.Int64(1),
				    ^

Check failure on line 90 in scm/github/github_client_test.go

github-actions / golangci

[golangci] scm/github/github_client_test.go#L90

SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)

Raw output


            scm/github/github_client_test.go:90:9: SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)
				ID: github.Int64(2),
				    ^

Check failure on line 104 in scm/github/github_client_test.go

github-actions / golangci

[golangci] scm/github/github_client_test.go#L104

SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)

Raw output


            scm/github/github_client_test.go:104:9: SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)
				ID: github.Int64(1),
				    ^

View more details on GitHub Actions