Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for btc block header deserialize #26

Merged
merged 16 commits into from
Jan 15, 2025
Merged

test: add test for btc block header deserialize #26

merged 16 commits into from
Jan 15, 2025

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented Jan 14, 2025

Description

  • Add tests for block header deserialize
  • Fix some miss understood in test data
  • Fix some TODOs.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary

@vuvoth vuvoth requested a review from a team as a code owner January 14, 2025 15:37
sczembor
sczembor reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review: improve the comments, some are unclear

vuvoth and others added 5 commits January 14, 2025 22:51
@vuvoth vuvoth requested a review from sczembor January 15, 2025 08:51
sczembor
sczembor reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few suggestions

btclightclient/btc_header_bytes.go Outdated Show resolved Hide resolved
btclightclient/btc_header_bytes_test.go Show resolved Hide resolved
btclightclient/partial_merkle_tree.go Outdated Show resolved Hide resolved
vuvoth and others added 2 commits January 15, 2025 17:57
@vuvoth
more tests
33cb7cb 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth @sczembor
Apply suggestions from code review
bf60071 
Co-authored-by: sczembor <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
sczembor
sczembor approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

btclightclient/btc_header_bytes_test.go Outdated Show resolved Hide resolved
@vuvoth @sczembor
Update btc_header_bytes_test.go
dee182c 
Co-authored-by: sczembor <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
@vuvoth vuvoth merged commit e669927 into master Jan 15, 2025
10 checks passed
@vuvoth vuvoth deleted the test/vu-more-tests branch January 15, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sczembor sczembor sczembor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vuvoth @sczembor