test: add test for btc block header deserialize

btclightclient/btc_header_bytes.go

@@ -3,18 +3,29 @@ package btclightclient
 import (
 	"bytes"
 	"encoding/hex"
+	"errors"
 
 	"github.com/btcsuite/btcd/wire"
 )
 
 // We don't want to make it compilicated yet :D
 // type BTCHeaderBytes []byte
-// const BTCHeaderSize = 80
+
+const BTCHeaderSize = 80
 
 func BlockHeaderFromHex(hexStr string) (wire.BlockHeader, error) {
-	data, _ := hex.DecodeString(hexStr)
 	var header wire.BlockHeader
+
+	if len(hexStr) != BTCHeaderSize*2 {
+		return header, errors.New("invalid header size, must have 80 bytes")
+	}
+
+	data, err := hex.DecodeString(hexStr)
+	if err != nil {
+		return header, err
+	}
+
 	reader := bytes.NewReader(data)
-	err := header.Deserialize(reader)
+	err = header.Deserialize(reader)
 	return header, err
 }

btclightclient/btc_header_bytes_test.go

@@ -0,0 +1,49 @@
+package btclightclient
+
+import (
+	"errors"
+	"testing"
+
+	"gotest.tools/assert"
+)
+
+func TestBTCHeaderFromHex(t *testing.T) {
+	type testCase struct {
+		name              string
+		headerHex         string
+		expectedBlockHash string
+		expectedError     error
+	}
+
+	run := func(t *testing.T, tc testCase) {
+		header, err := BlockHeaderFromHex(tc.headerHex)
+		blockHash := header.BlockHash()
+		if tc.expectedError != nil {
+			assert.Error(t, err, tc.expectedError.Error())
+		} else {
+			assert.NilError(t, err)
+			assert.Equal(t, tc.expectedBlockHash, blockHash.String())
+		}
+	}
+
+	testCases := []testCase{
+		{
+			name:              "happy test case",
+			headerHex:         "020000004cdba1415b2c6e7808c1b3c18df1374238454f7104203475bf01000000000000c17ea9d06015dc83902911cd24837a8ba4bdc0c1d72b873f906d921e06e48d2f984a8250ef75051a72a8061a",
+			expectedError:     nil,
+			expectedBlockHash: "0000000000000363d7f5f3341fb0b5b69949103e2d681591c9f737e4ea67e2a7",
+		},
+		{
+			name:              "invalid header length",
+			headerHex:         "020000004cdba1415b2c6e7808c1b3c18df1374238454f7104203475bf01000000000000c17ea9d06015dc83902911cd24837a8ba4bdc0c1d72b873f906d921e06e48d2f984a8250ef75051a72a8061ab",
+			expectedError:     errors.New("invalid header size, must have 80 bytes"),
+			expectedBlockHash: "0000000000000363d7f5f3341fb0b5b69949103e2d681591c9f737e4ea67e2a7",
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			run(t, tc)
+		})
+	}
+}

btclightclient/btc_light_client_store.go

@@ -121,7 +121,6 @@ func (s *MemStore) SetIsNotHead(bh chainhash.Hash) {
 	delete(s.latestBlockHashOfFork, bh)
 }
 
-// TODO: convert to iterator rather than returning a map
 func (s *MemStore) LatestBlockHashOfFork() []chainhash.Hash {
 	hashes := []chainhash.Hash{}
 	for h := range s.latestBlockHashOfFork {