Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for keccak again #16

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

yabirgb
Copy link
Contributor

@yabirgb yabirgb commented Dec 19, 2023

This PR drops pysha3 as dependency and adds support for keccak again

@sg495
Copy link
Contributor

sg495 commented Dec 20, 2023

Excellent work, thank you!

@sg495 sg495 merged commit a61ed06 into hashberg-io:main Dec 20, 2023
5 checks passed
@yabirgb yabirgb deleted the support-keccak branch December 20, 2023 08:38
@yabirgb
Copy link
Contributor Author

yabirgb commented Dec 20, 2023

Thanks for merging it. Could we get a release with the fix?

@sg495
Copy link
Contributor

sg495 commented Dec 20, 2023

Done, multiformats>=0.3.1.post4 has now been released with the fix.

yabirgb added a commit to yabirgb/rotki that referenced this pull request Dec 25, 2023
Update content-hash since I fixed it in filips123/ContentHashPy#3 fixing also
multimarts here hashberg-io/multiformats#16.

Now content-hash has mantained and updated dependencies and this allows to remove pinned dependencies that
we couldn't change due to constraints in those libraries
yabirgb added a commit to yabirgb/rotki that referenced this pull request Dec 25, 2023
Update content-hash since I fixed it in filips123/ContentHashPy#3 fixing also
multiformats here hashberg-io/multiformats#16.

Now content-hash has mantained and updated dependencies and this allows to remove pinned dependencies that
we couldn't change due to constraints in those libraries
LefterisJP pushed a commit to rotki/rotki that referenced this pull request Dec 25, 2023
Update content-hash since I fixed it in filips123/ContentHashPy#3 fixing also
multiformats here hashberg-io/multiformats#16.

Now content-hash has mantained and updated dependencies and this allows to remove pinned dependencies that
we couldn't change due to constraints in those libraries
OjusWiZard pushed a commit to OjusWiZard/rotki that referenced this pull request Dec 26, 2023
Update content-hash since I fixed it in filips123/ContentHashPy#3 fixing also
multiformats here hashberg-io/multiformats#16.

Now content-hash has mantained and updated dependencies and this allows to remove pinned dependencies that
we couldn't change due to constraints in those libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants