-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable support for keccak again #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yabirgb
force-pushed
the
support-keccak
branch
from
December 19, 2023 15:07
f899c0a
to
cc3ce4e
Compare
Excellent work, thank you! |
Thanks for merging it. Could we get a release with the fix? |
Closed
Done, |
yabirgb
added a commit
to yabirgb/rotki
that referenced
this pull request
Dec 25, 2023
Update content-hash since I fixed it in filips123/ContentHashPy#3 fixing also multimarts here hashberg-io/multiformats#16. Now content-hash has mantained and updated dependencies and this allows to remove pinned dependencies that we couldn't change due to constraints in those libraries
yabirgb
added a commit
to yabirgb/rotki
that referenced
this pull request
Dec 25, 2023
Update content-hash since I fixed it in filips123/ContentHashPy#3 fixing also multiformats here hashberg-io/multiformats#16. Now content-hash has mantained and updated dependencies and this allows to remove pinned dependencies that we couldn't change due to constraints in those libraries
LefterisJP
pushed a commit
to rotki/rotki
that referenced
this pull request
Dec 25, 2023
Update content-hash since I fixed it in filips123/ContentHashPy#3 fixing also multiformats here hashberg-io/multiformats#16. Now content-hash has mantained and updated dependencies and this allows to remove pinned dependencies that we couldn't change due to constraints in those libraries
OjusWiZard
pushed a commit
to OjusWiZard/rotki
that referenced
this pull request
Dec 26, 2023
Update content-hash since I fixed it in filips123/ContentHashPy#3 fixing also multiformats here hashberg-io/multiformats#16. Now content-hash has mantained and updated dependencies and this allows to remove pinned dependencies that we couldn't change due to constraints in those libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops pysha3 as dependency and adds support for keccak again