Fix NodeUpdateTransaction always updating node zero #10134
Merged
+47
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Sheehy <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10134 +/- ##
=========================================
Coverage 92.19% 92.19%
- Complexity 7860 7861 +1
=========================================
Files 956 956
Lines 32859 32862 +3
Branches 4151 4152 +1
=========================================
+ Hits 30295 30298 +3
Misses 1587 1587
Partials 977 977 ☔ View full report in Codecov by Sentry. |
steven-sheehy
added a commit
that referenced
this pull request
Jan 15, 2025
* Change node update to populate `createdTimestamp` if it's missing and an inner transaction. This is because nodes erroneously sent us updates instead of creates when migrating state. * Fix `NodeUpdateTransaction` updating the wrong node * Fix `NodeDeleteTransaction` deleting the wrong node Signed-off-by: Steven Sheehy <[email protected]>
2 tasks
steven-sheehy
added a commit
that referenced
this pull request
Jan 15, 2025
* Change node update to populate `createdTimestamp` if it's missing and an inner transaction. This is because nodes erroneously sent us updates instead of creates when migrating state. * Fix `NodeUpdateTransaction` updating the wrong node * Fix `NodeDeleteTransaction` deleting the wrong node Signed-off-by: Steven Sheehy <[email protected]>
2 tasks
steven-sheehy
added a commit
that referenced
this pull request
Jan 15, 2025
Cherry pick of #10134 to `release/0.121`. * Change node update to populate `createdTimestamp` if it's missing and an inner transaction. This is because nodes erroneously sent us updates instead of creates when migrating state. * Fix `NodeUpdateTransaction` updating the wrong node * Fix `NodeDeleteTransaction` deleting the wrong node Signed-off-by: Steven Sheehy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
createdTimestampif it's missing and an inner transaction. This is because nodes erroneously sent us updates instead of creates when migrating state.NodeUpdateTransactionupdating the wrong nodeNodeDeleteTransactiondeleting the wrong nodeRelated issue(s):
Fixes #10133
Notes for reviewer:
The protobuf spec silently changed in https://github.com/hashgraph/hedera-services/pull/16622/files after we implemented the logic.
Checklist