Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config V2 #58

Merged
merged 7 commits into from
Dec 19, 2024
Merged

Config V2 #58

merged 7 commits into from
Dec 19, 2024

Conversation

neonphog
Copy link
Collaborator

@neonphog neonphog commented Dec 18, 2024

  • Does away with the ModConfig trait.
  • We now just take anything Serializable for the set_module_config api.
  • and can get anything that implements DeserializeOwned for the get_module_config api.
  • Now supports runtime config alteration through register_entry_update_cb api.
  • And adds some warnings for "this param may be unused" and "nobody's listening to this runtime update".

@neonphog neonphog changed the title wip: Config V2 Config V2 Dec 18, 2024
@neonphog neonphog marked this pull request as ready for review December 18, 2024 16:54
@neonphog neonphog requested a review from a team December 18, 2024 16:54
@neonphog neonphog mentioned this pull request Dec 18, 2024
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, I like where it's going, just a few questions. Partly to make sure I'm following the code :)

crates/api/src/config.rs Outdated Show resolved Hide resolved
crates/api/src/config.rs Show resolved Hide resolved
crates/api/src/config.rs Show resolved Hide resolved
crates/api/src/config.rs Show resolved Hide resolved
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the answers to my many questions :) Looks good!

@neonphog neonphog merged commit 015ed22 into main Dec 19, 2024
5 checks passed
@neonphog neonphog deleted the config-v2 branch December 19, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants