-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ergoCubSN00*/ergoCubGazeboV1*] Add alljoints-inertials to be aligned with real ergoCub #232
[ergoCubSN00*/ergoCubGazeboV1*] Add alljoints-inertials to be aligned with real ergoCub #232
Conversation
Awaiting this: Before proceeding |
ceaf4fc
to
950a51e
Compare
Hi @Nicogene, I rebased this PR after solving the conflicts and now I put it ready for review. |
Am I missing something or the added .xml files were not added in the yarprobotinterface .xml file? |
I didn't add them since in the real robots they were not added to the yri launch file |
I am probably missing something, but then how are the users supposed to use them if they are not launched with the yarprobotinterface (in both the simulated and the real robot case)? |
Sorry, I just noticed that you wrote ths in the original description, I missed this. |
This is the twin of robotology/icub-models-generator#264. In this PR were added:
sensor
#222)alljoints-inertials_wrapper.xml
andalljoints-inertials_remapper.xml
to wrap up the inertials measurements (I didn't added them to the xml used by the yarprobotinterface by default);arms and legs IMU
asXMLBlobs
in the .yaml and manually added to the urdf;arms and legs IMU
assensors
in the .yaml, so the correspondent urdf can be regenerated.For the time being, I would keep this PR in draft since I want to see if the pose I added as XMLBlobs are correct.
cc @Nicogene @pattacini @traversaro