Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ergoCubSN00*/ergoCubGazeboV1*] Add alljoints-inertials to be aligned with real ergoCub #232

Merged

Conversation

martinaxgloria
Copy link
Member

@martinaxgloria martinaxgloria commented Mar 27, 2024

This is the twin of robotology/icub-models-generator#264. In this PR were added:

  • the .ini files for the inertials for the IMU sensors mounted on the FT of the arms and the legs. The ones of the feet were already added in:
  • the alljoints-inertials_wrapper.xml and alljoints-inertials_remapper.xml to wrap up the inertials measurements (I didn't added them to the xml used by the yarprobotinterface by default);
  • for ergoCub1.0 models (i.e. ergoCubGazeboV1, ergoCubGazeboV1_minContacts, ergoCubSN000): the arms and legs IMU as XMLBlobs in the .yaml and manually added to the urdf;
  • ergoCub1.1 models (i.e. ergoCubGazeboV1_1, ergoCubGazeboV1_1_minContacts, ergoCubSN001): the arms and legs IMU as sensors in the .yaml, so the correspondent urdf can be regenerated.

For the time being, I would keep this PR in draft since I want to see if the pose I added as XMLBlobs are correct.

cc @Nicogene @pattacini @traversaro

@martinaxgloria martinaxgloria self-assigned this Mar 27, 2024
@Nicogene
Copy link
Member

Nicogene commented Mar 28, 2024

Awaiting this:

Before proceeding

@martinaxgloria martinaxgloria force-pushed the add-alljoints-inertials branch from ceaf4fc to 950a51e Compare April 5, 2024 08:05
@martinaxgloria martinaxgloria marked this pull request as ready for review April 5, 2024 08:08
@martinaxgloria martinaxgloria requested a review from Nicogene April 5, 2024 08:08
@martinaxgloria
Copy link
Member Author

Hi @Nicogene, I rebased this PR after solving the conflicts and now I put it ready for review.

@martinaxgloria
Copy link
Member Author

Hi @Nicogene, thanks for generating the urdfs. I tried to launch the YRI with those models but I retrieved an error. In particular, there was a typo in a sensor name in alljoints-inertials_remapper. I fixed it here 50fe75c.

@Nicogene Nicogene merged commit a6828bd into icub-tech-iit:master Apr 5, 2024
4 checks passed
@traversaro
Copy link
Member

Am I missing something or the added .xml files were not added in the yarprobotinterface .xml file?

@martinaxgloria martinaxgloria deleted the add-alljoints-inertials branch April 5, 2024 13:06
@martinaxgloria
Copy link
Member Author

Am I missing something or the added .xml files were not added in the yarprobotinterface .xml file?

I didn't add them since in the real robots they were not added to the yri launch file

@traversaro
Copy link
Member

Am I missing something or the added .xml files were not added in the yarprobotinterface .xml file?

I didn't add them since in the real robots they were not added to the yri launch file

I am probably missing something, but then how are the users supposed to use them if they are not launched with the yarprobotinterface (in both the simulated and the real robot case)?

@traversaro
Copy link
Member

Sorry, I just noticed that you wrote ths in the original description, I missed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IMU sensors: alignment real ergoCub/iCub w/ simulated one
3 participants