Fix pageorder #31
Fix pageorder #31
Conversation
|
It looks like the tests are failing. Is this due to a fix required in #22 before you can get the /iiif/3/rbmsbk_ap2-v4_2001_V55N4/manifest.json manifest? |
|
Although its working in the public version: https://iiif.archive.org//iiif/3/rbmsbk_ap2-v4_2001_V55N4/manifest.json |
|
That's the wrong test, it's the next one that is throwing the error ( And yes, that is one of the bugs that will be fixed by #22, it's the issue described in #14 So once #22 is ready to go, this can go ahead assuming you think it's all fine |
|
|
||
| # Setting logic for paging behavior and starting canvases | ||
| # Start with paged (default) or individual behaviors | ||
| try: |
There was a problem hiding this comment.
Maybe add comment saying that it won't be set if the book reader brOptions has something other than mode/1up
| except: | ||
| manifest.behavior = "paged" | ||
|
|
||
| # Then set left-to-right or right-to-left if present |
There was a problem hiding this comment.
Add test to see if pageProgression key exists in brOptions or try catch Key not found error.
This fixes #9, but should be merged in after #22