-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pageorder #31
Merged
Merged
Fix pageorder #31
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1dc132b
Add logic for paged behavior and page-direction
hadro 728ba62
Put logic in the right place
hadro 0822862
Add tests
hadro 9dec13f
Merge branch 'main' into fix-pageorder
hadro 11e73a4
Add check for presence of direction before setting
digitaldogsbody 49d06ff
Merge branch 'main' into fix-pageorder
hadro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -387,6 +387,25 @@ def create_manifest3(identifier, domain=None, page=None): | |
# id=f"https://iiif.archivelab.org/iiif/{identifier}${pageCount}/canvas", | ||
# label=f"{page['leafNum']}") | ||
pageCount += 1 | ||
|
||
|
||
# Setting logic for paging behavior and starting canvases | ||
# Start with paged (default) or individual behaviors | ||
try: | ||
if bookreader['data']['brOptions']['defaults'] == "mode/1up": | ||
manifest.behavior = "individuals" | ||
except: | ||
manifest.behavior = "paged" | ||
|
||
# Then set left-to-right or right-to-left if present | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add test to see if pageProgression key exists in brOptions or try catch Key not found error. |
||
if bookreader['data']['brOptions']['pageProgression'] == "lr": | ||
viewingDirection = "left-to-right" | ||
elif bookreader['data']['brOptions']['pageProgression'] == "rl": | ||
viewingDirection = "right-to-left" | ||
if viewingDirection: | ||
manifest.viewingDirection = viewingDirection | ||
|
||
|
||
elif mediatype == 'image': | ||
singleImage(metadata, identifier, manifest, uri) | ||
elif mediatype == 'audio' or mediatype == 'etree': | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add comment saying that it won't be set if the book reader brOptions has something other than mode/1up