Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROS-O] fixup 6ac62fef5caba52cbfa71c093b242a1f0b5a1b88 #2851

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Nov 12, 2024

Drop unused catkin_python_setup().
The call and setup.py are only required when defining python modules, but jsk_recognition_msgs does not expose a python package (aside from the autogenerated package for the messages).

This got noticed because Debian's python setuptools complains about missing package list in setup.py:

error: Multiple top-level packages discovered in a flat-layout: ['srv', 'msg', 'debian', 'action', 'sample'].

To avoid accidental inclusion of unwanted files or directories, setuptools will not proceed with this build.

If you are trying to create a single distribution with multiple packages on purpose, you should not rely on automatic discovery. Instead, consider the following options:

1. set up custom discovery (`find` directive with `include` or `exclude`)
2. use a `src-layout`
3. explicitly set `py_modules` or `packages` with a list of names

To find more information, look for "package discovery" on setuptools docs. CMake Error at catkin_generated/safe_execute_install.cmake:4 (message):

  execute_process(/<<BUILDDIR>>package/.obj-x86_64-linux-gnu/catkin_generated/python_distutils_install.sh)
  returned error code
Call Stack (most recent call first):
  cmake_install.cmake:46 (include)

@mqcmd196

Drop unused catkin_python_setup().
The call and setup.py are only required when defining python modules,
but jsk_recognition_msgs does not expose a python package (aside from
the autogenerated package for the messages).

This got noticed because Debian's python setuptools complains about
missing package list in setup.py:

---
error: Multiple top-level packages discovered in a flat-layout: ['srv', 'msg', 'debian', 'action', 'sample'].

To avoid accidental inclusion of unwanted files or directories,
setuptools will not proceed with this build.

If you are trying to create a single distribution with multiple packages
on purpose, you should not rely on automatic discovery.
Instead, consider the following options:

1. set up custom discovery (`find` directive with `include` or `exclude`)
2. use a `src-layout`
3. explicitly set `py_modules` or `packages` with a list of names

To find more information, look for "package discovery" on setuptools docs.
CMake Error at catkin_generated/safe_execute_install.cmake:4 (message):

  execute_process(/<<BUILDDIR>>package/.obj-x86_64-linux-gnu/catkin_generated/python_distutils_install.sh)
  returned error code
Call Stack (most recent call first):
  cmake_install.cmake:46 (include)
---
@v4hn v4hn mentioned this pull request Nov 18, 2024
@mqcmd196
Copy link
Member

@k-okada Please review if you have time

pazeshun added a commit to pazeshun/jsk_3rdparty that referenced this pull request Dec 12, 2024
pazeshun added a commit to pazeshun/jsk_3rdparty that referenced this pull request Dec 12, 2024
pazeshun added a commit to pazeshun/jsk_3rdparty that referenced this pull request Dec 12, 2024
pazeshun added a commit to pazeshun/jsk_3rdparty that referenced this pull request Dec 12, 2024
pazeshun added a commit to pazeshun/jsk_robot that referenced this pull request Dec 12, 2024
@k-okada k-okada merged commit 93a9871 into jsk-ros-pkg:master Dec 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants