[ROS-O] patches #2853
Merged
[ROS-O] patches #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop unused catkin_python_setup(). The call and setup.py are only required when defining python modules, but jsk_recognition_msgs does not expose a python package (aside from the autogenerated package for the messages). This got noticed because Debian's python setuptools complains about missing package list in setup.py: --- error: Multiple top-level packages discovered in a flat-layout: ['srv', 'msg', 'debian', 'action', 'sample']. To avoid accidental inclusion of unwanted files or directories, setuptools will not proceed with this build. If you are trying to create a single distribution with multiple packages on purpose, you should not rely on automatic discovery. Instead, consider the following options: 1. set up custom discovery (`find` directive with `include` or `exclude`) 2. use a `src-layout` 3. explicitly set `py_modules` or `packages` with a list of names To find more information, look for "package discovery" on setuptools docs. CMake Error at catkin_generated/safe_execute_install.cmake:4 (message): execute_process(/<<BUILDDIR>>package/.obj-x86_64-linux-gnu/catkin_generated/python_distutils_install.sh) returned error code Call Stack (most recent call first): cmake_install.cmake:46 (include) ---
- PCL_LIBRARIES has to be added explicitly to pull in VTK, which is required in `pointcloud_to_stl_nodelet.cpp` by using `pcl::io::savePolygonFileSTL(ss.str(),triangles)`. (the respective header includes VTK headers) - define pcl_isfinite again which got removed from PCL for compatibility with old versions - ros::topic::waitForMessage still returns a boost::shared_ptr.
pcl removed the method by 1.13, no harm in defining it as '#define pcl_isfinite(x) std::isfinite(x)'
…ee/octree_search.h>
…uboid_particles_top_n_nodelet.cpp, due to undefined reference to 'pcl::FilterIndices<pcl::tracking::ParticleCuboid>::applyFilter(pcl::PointCloud<pcl::tracking::ParticleCuboid>&)'
k-okada
force-pushed
the
obese-devel
branch
9 times, most recently
from
5df3b0a to
03ae72b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #2851 , feel free to merge that one first and we will rebase
obese-devel.The second commit includes patches to compile
jsk_pcl_ros_utilswith PCL 1.13 (Debian bookworm+).jsk_pcl_rosalso depends on currently broken packages in 3rd_party, so I'm waiting for this before I'll have a look.@mqcmd196