Force BR to always be display:inline #338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BR shouldn't be handled just like any block element (a height applied to it is not ensured by Firefox or Calibre).
We get more similar results with Firefox/Calibre by just forcing all BR to be
display: inline
.Revert a bit of 36ae6cc (from #337) (but let the logic in for
<empty-line>
).More details in koreader/koreader#6069 (comment) and #172 (comment).
Thought about removing the height in epub.css:
to keep lines aligned with .txt documents - but they use PRE for each line, which has some top and bottom margins, so preventing any constant line-height alignment.
But just noticed that if you "Clear all external styles" with txt document, you get an alternate rendering, without monospace fonts, no margin for PRE, no height for empty-line, so something that I find more readable and that has constant line-height aligmnent:
I'd like to rename that menu item:
Clear all external styles
to justNone
.That long sentence is a bit unclear about what it does, what are external styles, why the plural (ok, it's many styles in a single user agent CSS), and styletweaks still work when this is checked.
Thoughts?
This change is