bump crengine: text typography by language #6069
Conversation
|
Mhhh, noticable change with leaves.epub because of the Source is: with KOReader before on the left / with this PR on the right:
Calibre and Firefox show it as:
while KOReader now adds an empty line. Although logically, if it's a block element met inside a inline context, it should break the inline context to be displayed as a block and ensure its height. So, may be it's not as simple as A or B in koreader/crengine#172 (comment) - although A would behave correctly. Text case: <p>abc
<br style="display: block"/>
def</p> |
Includes: - Fix a few clang-tidy warnings - Add support for <img src="data:image/png;base64,...> - XML parsing: add more HTML5 named entities, optimize search - Text: fix standalone BR not making an empty line - Fix BR with "display: block" not making an empty line - Fix hyphens from soft-hyphens not part of highlighted segments - Use libunibreak for line breaking - Adds TextLangMan for text typography by language Tweak ReaderHyphenation to work with the new TextLangMan (even if it will be replaced soon by ReaderTypography).
|
OK, so still some differences with leaves.epub, but this time, it's for the best: some previously discarded BRs now generate empty lines:
And above page displays now as Firefox & Calibre: So, updating unit tests... |
|
Just some note about leaves.epub: the links from the KOReader TOC work fine - while the links from the in-book TOC (below "CONTENTS" in the screenshots above) target some id at the bottom of the previous poem. [some poem]
<p class="calibre2"><a id="link2H_4_0007"><!-- H2 anchor --></a></p> <!-- id of the next poem -->
<div class="c2"><br class="calibre1"/>
<br class="calibre1"/>
<br class="calibre1"/>
<br class="calibre1"/></div>
</body></html>
[ next poem in a new DocFragment <body><html>...]As each are in a DocFragment, we make a new page for each poem, so the link target is the bottom of the previous poem. |
Includes koreader/crengine#337 :
Tweak ReaderHyphenation to work with the new TextLangMan (even if it will be replaced soon by ReaderTypography).
(Removed uneeded onUpdateToc() which were useless as they were done before the new rendering - another one was done elsewhere after the re-rendering)
This is just a bump to get a build with the new crengine code, which should still work with our current single global hyphenation language.
This change is