[doc] Don't strip markdown headings from HW checklist #3458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checklist template is processed by Mako, which uses `##` as template comment. Use syntax which avoids stripping the headings out. (The Mako comment behavior cannot really be configured; we could write a pre-processor which does the escaping, but since we're only having a single template here and many invocations of Mako in different scripts, doing that seems fragile. See also sqlalchemy/mako#268.) Signed-off-by: Philipp Wagner <[email protected]>
rswarbrick
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checklist template is processed by Mako, which uses
##as templatecomment. Use syntax which avoids stripping the headings out.
(The Mako comment behavior cannot really be configured; we could write a
pre-processor which does the escaping, but since we're only having a
single template here and many invocations of Mako in different scripts,
doing that seems fragile. See also
sqlalchemy/mako#268.)