-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead code (part 1) #3947
Conversation
Please do not merge this until we cut the |
@Anish9901 This is ready for review, but (again) don't merge until we cut the release branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest in git history!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can completely remove this file in your subsequent PR, I don't see is_superuser
and is_self
used anywhere.
They're used in mathesar.api.ui.permissions.users.UserAccessPolicy
via 🪄magic🪄 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to have this file around in our codebase, I frequently use it to test import as well as test type inference manually. @mathemancer can you consider restoring this file in your subsequent PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point, but I'd like to get everything completely out first, then add things back in that we still want later. In that example, we'd want to have a separate directory where "human testing" data or files would reside.
I suggest making an issue for adding "human testing" data to the repo where we can discuss further. (maybe we'd actually use the mathesar-data-playground
repo or something)
Related to #3946
Removes dead code from the
mathesar
library.Technical details
Main parts removed are:
urls.py
)This PR does not remove:
db
library.Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin