Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code (part 1) #3947

Merged
merged 45 commits into from
Oct 15, 2024
Merged

Remove dead code (part 1) #3947

merged 45 commits into from
Oct 15, 2024

Conversation

mathemancer
Copy link
Contributor

Related to #3946

Removes dead code from the mathesar library.

Technical details

Main parts removed are:

  • API tests which aren't relevant for the new architecture
  • unused paths (in urls.py)
  • Unused viewsets
  • Unused serializers
  • Unused API exception classes
  • Dependencies of the above code (which aren't otherwise used)

This PR does not remove:

  • Any models, used or not
  • Any code that supports models
  • Any code from the db library.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mathemancer mathemancer added this to the 0.2.0-testing.2 milestone Oct 10, 2024
@mathemancer
Copy link
Contributor Author

Please do not merge this until we cut the 0.2.0-testing.1 branch!

@mathemancer
Copy link
Contributor Author

@Anish9901 This is ready for review, but (again) don't merge until we cut the release branch.

@mathemancer mathemancer requested a review from Anish9901 October 10, 2024 08:22
@mathemancer mathemancer marked this pull request as ready for review October 10, 2024 14:32
@mathemancer mathemancer changed the title Remove dead code Remove dead code (part 1) Oct 10, 2024
@kgodey kgodey added the pr-status: review A PR awaiting review label Oct 12, 2024
Copy link
Member

@Anish9901 Anish9901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest in git history!

Copy link
Member

@Anish9901 Anish9901 Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can completely remove this file in your subsequent PR, I don't see is_superuser and is_self used anywhere.

They're used in mathesar.api.ui.permissions.users.UserAccessPolicy via 🪄magic🪄 .

Copy link
Member

@Anish9901 Anish9901 Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to have this file around in our codebase, I frequently use it to test import as well as test type inference manually. @mathemancer can you consider restoring this file in your subsequent PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point, but I'd like to get everything completely out first, then add things back in that we still want later. In that example, we'd want to have a separate directory where "human testing" data or files would reside.

I suggest making an issue for adding "human testing" data to the repo where we can discuss further. (maybe we'd actually use the mathesar-data-playground repo or something)

@Anish9901 Anish9901 enabled auto-merge October 15, 2024 19:26
@Anish9901 Anish9901 added this pull request to the merge queue Oct 15, 2024
Merged via the queue into develop with commit f775dba Oct 15, 2024
39 checks passed
@Anish9901 Anish9901 deleted the remove_dead_code branch October 15, 2024 19:40
@seancolsen seancolsen modified the milestones: v0.2.0-testing.2, v0.2.0 (beta release) Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants