Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code (part 1) #3947

Merged
merged 45 commits into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from 44 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
2bfcf11
remove tests for schema and db reflection
mathemancer Oct 8, 2024
7e6f416
remove REST API filter-related tests
mathemancer Oct 8, 2024
5d063b4
remove unneeded display option inference code
mathemancer Oct 8, 2024
59877c2
remove column REST API endpoint tests
mathemancer Oct 8, 2024
23eda7b
remove record, db, and constraint REST API tests
mathemancer Oct 8, 2024
216654b
remove dependents, function, links, REST API tests
mathemancer Oct 8, 2024
e2ab14b
remove reflection and schema REST API tests
mathemancer Oct 8, 2024
6e70d57
remove remaining unneeded REST API tests (other than query)
mathemancer Oct 8, 2024
886aab9
remove query REST API tests
mathemancer Oct 8, 2024
333e3fd
remove unused test data files
mathemancer Oct 8, 2024
71d3076
remove unused imports from conftest
mathemancer Oct 8, 2024
e9fd321
remove connection REST API endpoint and related code
mathemancer Oct 8, 2024
e73667b
remove shared object related API tests
mathemancer Oct 8, 2024
a0149e7
remove shared object related code
mathemancer Oct 8, 2024
81c958c
remove version endpoint related code
mathemancer Oct 8, 2024
c7523dc
remove failing versionviewset import
mathemancer Oct 8, 2024
e0b81d7
remove some unused imports
mathemancer Oct 8, 2024
02de516
remove record listing REST API code
mathemancer Oct 8, 2024
d3b70ce
remove columns REST API code
mathemancer Oct 8, 2024
f44c3b4
remove constraint REST API code
mathemancer Oct 8, 2024
7e26979
remove query (exploration) REST API code
mathemancer Oct 8, 2024
e84f197
remove links REST API code
mathemancer Oct 8, 2024
ca19eb4
remove table settings REST API code
mathemancer Oct 9, 2024
ed3f42f
revert changes to models to costrain scope
mathemancer Oct 9, 2024
870cc6e
remove table REST API code
mathemancer Oct 9, 2024
8805ec2
remove schema REST API code
mathemancer Oct 9, 2024
69fa100
remove unused permissions-related REST API code
mathemancer Oct 9, 2024
d42a403
remove unneeded paginators
mathemancer Oct 9, 2024
e4d0213
remove dangling imports
mathemancer Oct 9, 2024
9483125
remove unneeded REST API util functions
mathemancer Oct 9, 2024
681f504
remove unneeded filters code
mathemancer Oct 9, 2024
631a468
remove unused mathesar.database code
mathemancer Oct 9, 2024
7a217a8
remove tests referring to removed code
mathemancer Oct 9, 2024
61b44d2
remove unused database, data_import API exceptions
mathemancer Oct 9, 2024
8738b40
remove unneeded API exception classes
mathemancer Oct 10, 2024
5ab96f6
remove unneeded migration file
mathemancer Oct 10, 2024
5708929
remove unneeded mathesar.functions module
mathemancer Oct 10, 2024
de0004b
remove installation onto user DB from root install
mathemancer Oct 10, 2024
0a30c2b
add explicit model import to force registration
mathemancer Oct 10, 2024
24d07fb
remove connections RPC function and dependencies
mathemancer Oct 10, 2024
6bfaec4
remove dangling utils functions
mathemancer Oct 10, 2024
21ad7a0
remove dangling imports
mathemancer Oct 10, 2024
7e81806
Merge branch 'develop' into remove_dead_code
mathemancer Oct 10, 2024
61eb385
switch out unused variable
mathemancer Oct 10, 2024
e573704
Merge branch 'develop' into remove_dead_code
Anish9901 Oct 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/settings/common_settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ def pipe_delim(pipe_string):
'mathesar.rpc.collaborators',
'mathesar.rpc.columns',
'mathesar.rpc.columns.metadata',
'mathesar.rpc.connections',
'mathesar.rpc.constraints',
'mathesar.rpc.data_modeling',
'mathesar.rpc.databases',
Expand Down
21 changes: 5 additions & 16 deletions docs/docs/api/rpc.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,19 @@ To use an RPC function:

!!! example

To call function `add_from_known_connection` from the `connections` section of this page, you'd send something like:
To call function `tables.list` from the Tables section of this page, you'd send something like:

`POST /api/rpc/v0/`b

```json
{
"jsonrpc": "2.0",
"id": 234,
"method": "connections.add_from_known_connection",
"method": "tables.list",
"params": {
"nickname": "anewconnection",
"db_name": "mynewcooldb"
},
"schema_oid": 47324,
"database_id": 1
}
}
```

Expand Down Expand Up @@ -128,17 +128,6 @@ Unrecognized errors from a given library return a "round number" code, so an unk
- disconnect
- ConfiguredDatabaseInfo


## Connections

::: connections
options:
members:
- add_from_known_connection
- add_from_scratch
- grant_access_to_user
- ConnectionReturn

## Constraints

::: constraints
Expand Down
3 changes: 0 additions & 3 deletions mathesar/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
from mathesar.models.deprecated import Table, Schema, DataFile
from mathesar.models.users import User
from mathesar.models.query import Exploration
from mathesar.models.shares import SharedTable, SharedQuery


class MathesarUserAdmin(UserAdmin):
Expand All @@ -25,5 +24,3 @@ class MathesarUserAdmin(UserAdmin):
admin.site.register(DataFile)
admin.site.register(User, MathesarUserAdmin)
admin.site.register(Exploration)
admin.site.register(SharedTable)
admin.site.register(SharedQuery)
Empty file.
30 changes: 0 additions & 30 deletions mathesar/api/db/permissions/columns.py

This file was deleted.

23 changes: 0 additions & 23 deletions mathesar/api/db/permissions/constraint.py

This file was deleted.

36 changes: 0 additions & 36 deletions mathesar/api/db/permissions/database.py

This file was deleted.

94 changes: 0 additions & 94 deletions mathesar/api/db/permissions/query.py

This file was deleted.

25 changes: 0 additions & 25 deletions mathesar/api/db/permissions/query_table.py

This file was deleted.

26 changes: 0 additions & 26 deletions mathesar/api/db/permissions/records.py

This file was deleted.

75 changes: 0 additions & 75 deletions mathesar/api/db/permissions/schema.py

This file was deleted.

Loading
Loading