Convert many components to Composition API #100
Conversation
Mysterious-Dev
changed the title
Mysterious-Dev
changed the title
|
Merge conflicts fixed ^^. |
|
@brawaru I've applied your suggestions ^^. |
|
Would you be okay with splitting this pull request into several smaller pull requests per component? Would be easier to review and merge at least some of these changes, rather than trying merge everything all at once. |
No worries, I'll take care of it over the weekend. It's true that it will be easier to review ^^. |
|
I think it's fine to be one PR, it's only four files. |
| @@ -49,66 +49,63 @@ | |||
| </a> | |||
| </div> | |||
| </template> | |||
| <script setup> | |||
| <script setup lang="ts"> | |||
There was a problem hiding this comment.
On second thought, a separate PR for doing typescript conversions separate from the composition API conversions would be nice.
There was a problem hiding this comment.
I think split on components makes a lot more sense because the PRs will atomic and independent, thus can be accepted quicker (as long as you are going to review and merge).
Split on Composition and TypeScript conversions makes less sense, since TypeScript conversion achieves the same goal that Composition conversion achieves. E.g., defineProps with TypeScript generic emits the same code that defineProps with options argument.
It's just twice the effort. There's no crazy TypeScript shenanigans going on to really justify a separate review. But it's up to you.
All is in the title ^^.
Components converted :