Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

Convert Checkbox component to Composition API #126

Merged

Conversation

Mysterious-Dev
Copy link
Contributor

All is in the title ^^.

Related to #100 (comment)

lib/components/base/Checkbox.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@brawaru brawaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left an optional suggestion with non-breaking fixes to some minor mistakes in the original options API code. Feel free to apply if you think they're worth including in this PR.

lib/components/base/Checkbox.vue Outdated Show resolved Hide resolved
@Geometrically Geometrically merged commit 9211627 into modrinth:master Nov 13, 2023
1 check passed
@Mysterious-Dev Mysterious-Dev deleted the checkbox-composition-api branch November 13, 2023 20:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants