Add displayName as a possible tag for k8s candidate matching #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entityBot
approved these changes
Jan 14, 2025
entityBot
approved these changes
Jan 14, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -4,8 +4,10 @@ lookups: | |||
| - domain: INFRA | |||
| type: KUBERNETESCLUSTER | |||
| tags: | |||
| matchingMode: ANY | |||
| matchingMode: FIRST | |||
There was a problem hiding this comment.
We are changing the matching mode and it is not present on the description of the PR.
Could we please include the reasoning for this change on the PR description?
otaviocarvalho
requested changes
Jan 15, 2025
otaviocarvalho
approved these changes
Jan 15, 2025
rohit-bandlamudi-nr
pushed a commit
to rohit-bandlamudi-nr/entity-definitions
that referenced
this pull request
Jan 17, 2025
…c#1856) Co-authored-by: nephyst <[email protected]> Co-authored-by: Otávio Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant information
Adding displayName as a possible tag for matching k8s candidate relationships. We expect displayName to match in the majority of cases, which is why it is being checked before k8s.cluster.name.
The matching mode is being changed to FIRST as we are using this to determine which cluster is being managed by a specific agent, and only want a single target entity to have a relationship synthesized.
Checklist
identifierwill be unique and valid.