Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add displayName as a possible tag for k8s candidate matching #1856

Merged
merged 2 commits into from
Jan 15, 2025
+3 −1
Merged

Add displayName as a possible tag for k8s candidate matching #1856

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
777607b
Add displayName as a possible tag for k8s candidate matching
nephyst Jan 14, 2025
bb32fde
Merge branch 'main' into k8s-candidate-rules
otaviocarvalho Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion relationships/candidates/KUBERNETESCLUSTER.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ lookups:
- domain: INFRA
type: KUBERNETESCLUSTER
tags:
matchingMode: ANY
matchingMode: FIRST
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are changing the matching mode and it is not present on the description of the PR.

Could we please include the reasoning for this change on the PR description?

predicates:
- tagKeys: [ "displayName" ]
field: cluster.name
- tagKeys: [ "k8s.cluster.name" ]
field: cluster.name
onMatch:
Expand Down
Loading